Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      This is a place for accumulating error message improvements for the Hive parser so that we can update a bunch in batch.

        Activity

        Hide
        Holden Karau added a comment -

        I tried to create a reviewboard account, but registration seems to be broken. I've attached a patch which should result in a clearer error message.

        Show
        Holden Karau added a comment - I tried to create a reviewboard account, but registration seems to be broken. I've attached a patch which should result in a clearer error message.
        Hide
        Holden Karau added a comment -

        Hi Carl,

        I think you are mistaken as to what is causing the problem. The name 'LINES' is a reserved token, hence it is not a valid identifier. For example if you try create table lines(line string) you will see the same error message. The request for a valid identifier by the parser is correct. I will look at adding a patch which outputs the token which is not a valid identifier if this case so that when a reserved word is used it is clearer.

        Cheers,

        Holden

        P.S.

        I could be wrong this is my first time digging through the hive code.

        Show
        Holden Karau added a comment - Hi Carl, I think you are mistaken as to what is causing the problem. The name 'LINES' is a reserved token, hence it is not a valid identifier. For example if you try create table lines(line string) you will see the same error message. The request for a valid identifier by the parser is correct. I will look at adding a patch which outputs the token which is not a valid identifier if this case so that when a reserved word is used it is clearer. Cheers, Holden P.S. I could be wrong this is my first time digging through the hive code.
        Hide
        Carl Steinbach added a comment -
        
        create table lines(string line)
        PARTITIONED BY (rownum BIGINT)
        STORED AS SEQUENCEFILE;
        FAILED: Parse Error:
        line 1:13 mismatched input 'lines' expecting Identifier in create statement
                                                     ^^^^^^^^^^
        

        Instead of saying "Identifier", it should say "Type" or "column type".

        Show
        Carl Steinbach added a comment - create table lines(string line) PARTITIONED BY (rownum BIGINT) STORED AS SEQUENCEFILE; FAILED: Parse Error: line 1:13 mismatched input 'lines' expecting Identifier in create statement ^^^^^^^^^^ Instead of saying "Identifier", it should say "Type" or "column type".

          People

          • Assignee:
            Unassigned
            Reporter:
            Carl Steinbach
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development