[HIVE-19391] RowContainer.setupWriter hangs when the file creation failed

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.0.0
• Component/s: SQL
• Assignee: Unassigned Assign to me
• Reporter: John Doe
• Created: 03/May/18 01:50
• Updated: 22/Jun/18 22:12

Description

The while loop in the RowContainer.setupWriter function hangs endlessly when the file creation failed, causing the delete() returns false.

The file creation failure can be caused by different reasons, e.g., disk full.

Here is the code snippet.

 

  protected void setupWriter() throws HiveException {
    try {

      if ( tmpFile != null ) {
        return;
      }

      String suffix = ".tmp";
      if (this.keyObject != null) {
        suffix = "." + this.keyObject.toString() + suffix;
      }

      while (true) {
        parentFile = File.createTempFile("hive-rowcontainer", ""); //file creation failed
        boolean success = parentFile.delete() && parentFile.mkdir(); //delete returns false
        if (success) {
          break;
        }
        LOG.debug("retry creating tmp row-container directory...");
      }
      ...
  }