Hive
  1. Hive
  2. HIVE-1928

GRANT/REVOKE should handle privileges as tokens, not identifiers

    Details

    • Hadoop Flags:
      Reviewed

      Description

      The grammar for the GRANT and REVOKE Privileges statements currently handle the list of privileges as a list of
      identifiers. Since most of the privileges are also keywords in the HQL grammar this requires users
      to individually quote-escape each of the privileges, e.g:

      grant `Create` on table authorization_part to user hive_test_user;
      grant `Update` on table authorization_part to user hive_test_user;
      grant `Drop` on table authorization_part to user hive_test_user;
      grant `select` on table src to user hive_test_user;
      

      Both MySQL and the SQL standard treat privileges as tokens. Hive should do the same.

      1. HIVE-1928.2.patch
        78 kB
        Jonathan Natkins
      2. HIVE-1928.1.patch
        76 kB
        Jonathan Natkins

        Issue Links

          Activity

          Hide
          Carl Steinbach added a comment -

          Committed to branch-0.7 and trunk. Thanks Natty!

          Show
          Carl Steinbach added a comment - Committed to branch-0.7 and trunk. Thanks Natty!
          Hide
          Jonathan Natkins added a comment -

          Realized I missed one of the tests that needed updating

          Show
          Jonathan Natkins added a comment - Realized I missed one of the tests that needed updating
          Hide
          Carl Steinbach added a comment -

          +1. Will commit if tests pass.

          Show
          Carl Steinbach added a comment - +1. Will commit if tests pass.
          Show
          Jonathan Natkins added a comment - https://reviews.apache.org/r/427/
          Hide
          Carl Steinbach added a comment -

          Downgrading to critical.

          Show
          Carl Steinbach added a comment - Downgrading to critical.

            People

            • Assignee:
              Jonathan Natkins
              Reporter:
              Carl Steinbach
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development