Hive
  1. Hive
  2. HIVE-192

DUPLICATE: Add TIMESTAMP column type for thrift dynamic_type

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Query Processor
    • Labels:

      Description

      create table something2 (test timestamp);
      ERROR: DDL specifying type timestamp which has not been defined
      java.lang.RuntimeException: specifying type timestamp which has not been defined
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.FieldType(thrift_grammar.java:1879)
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Field(thrift_grammar.java:1545)
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.FieldList(thrift_grammar.java:1501)
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Struct(thrift_grammar.java:1171)
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.TypeDefinition(thrift_grammar.java:497)
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Definition(thrift_grammar.java:439)
      at org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Start(thrift_grammar.java:101)
      at org.apache.hadoop.hive.serde2.dynamic_type.DynamicSerDe.initialize(DynamicSerDe.java:97)
      at org.apache.hadoop.hive.metastore.MetaStoreUtils.getDeserializer(MetaStoreUtils.java:180)
      at org.apache.hadoop.hive.ql.metadata.Table.initSerDe(Table.java:141)
      at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:202)
      at org.apache.hadoop.hive.ql.exec.DDLTask.createTable(DDLTask.java:641)
      at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:98)
      at org.apache.hadoop.hive.ql.Driver.run(Driver.java:215)
      at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:174)
      at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:207)
      at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:305)

      1. TIMESTAMP_specification.txt
        12 kB
        Shyam Sundar Sarkar
      2. create_2.q.txt
        0.6 kB
        Shyam Sundar Sarkar
      3. Hive-192.patch.txt
        2 kB
        Shyam Sundar Sarkar

        Issue Links

          Activity

          Johan Oskarsson created issue -
          Shyam Sundar Sarkar made changes -
          Field Original Value New Value
          Attachment Hive_diff [ 12401746 ]
          Shyam Sundar Sarkar made changes -
          Attachment TIMESTAMP_specification.txt [ 12401830 ]
          Shyam Sundar Sarkar made changes -
          Attachment Hive_diff [ 12401746 ]
          Ashish Thusoo made changes -
          Priority Blocker [ 1 ] Critical [ 2 ]
          Shyam Sundar Sarkar made changes -
          Attachment create_2.q.txt [ 12404080 ]
          Shyam Sundar Sarkar made changes -
          Attachment TestCliTimestampDriver.java.txt [ 12404081 ]
          Johan Oskarsson made changes -
          Fix Version/s 0.4.0 [ 12313714 ]
          Fix Version/s 0.2.0 [ 12313565 ]
          Priority Critical [ 2 ] Major [ 3 ]
          Shyam Sundar Sarkar made changes -
          Attachment TestCliTimestampDriver.java.txt [ 12404081 ]
          Shyam Sundar Sarkar made changes -
          Comment [ This is the diff file for showing the changes in the Hive.g grammar with new TimestampType added.

          Thanks,
          shyam_sarkar@yahoo.com ]
          Shyam Sundar Sarkar made changes -
          Comment [ Functional test for Timestamp. ]
          Shyam Sundar Sarkar made changes -
          Comment [ I added functional test cases for TIMESTAMP. Can someone suggest more test cases?

          The Java code for test driver is attached ::

          (/hive/build/ql/test/src/org/apache/hadoop/hive/cli/TestCliTimestampDriver.java)

          Can someone please tell me how do I get results and logs for the following call ::

          qt = new QTestUtil("/home/ssarkar/hive/ql/src/test/results/clientpositive", "/home/ssarkar/hive/build/ql/test/logs/clientpositive");

          I am getting Exception.

          At this point can I add any arbitrary results and log files?

          Thanks,
          shyam_sarkar@yahoo.com

          ]
          Shyam Sundar Sarkar made changes -
          Comment [ Can someone please help me to find out why I am getting exception in setUp() method inside TestCliTimestampDriver.java file (attached) ?
          I followed all lines and methods from existing CliDriver test class in Hive and modified just to test TIMESTAMP sysntax in some queries.
          I stepped through the setUp under debug mode and it gave error in QTestUtil at the line :

          private String tmpdir = System.getProperty("user.dir")+"/../build/ql/tmp";

          where "user.dir" was home dir of hive (not inside build dir).

          If I run the general CliDriver tests and then try to run my test for TIMESTAMP, above exception does not show up.
          However, I am getting exception at the line :

          testFiles = conf.get("test.data.files").replace('\\', '/').replace("c:", "");

          inside QTestUtil constructor.

          My question :: Why am I getting setUp() exception when I do not need a data file ?
          Can someone suggest a specific step that I am missing ?

          Thanks,
          shyam_sarkar@yahoo.com ]
          Ashish Thusoo made changes -
          Assignee Shyam Sundar Sarkar [ ssarkar ]
          Johan Oskarsson made changes -
          Issue Type Bug [ 1 ] New Feature [ 2 ]
          Fix Version/s 0.5.0 [ 12314156 ]
          Fix Version/s 0.4.0 [ 12313714 ]
          Namit Jain made changes -
          Fix Version/s 0.5.0 [ 12314156 ]
          Zheng Shao made changes -
          Affects Version/s 0.6.0 [ 12314524 ]
          Affects Version/s 0.2.0 [ 12313565 ]
          Carl Steinbach made changes -
          Issue Type New Feature [ 2 ] Bug [ 1 ]
          Fix Version/s 0.3.0 [ 12313637 ]
          Affects Version/s 0.6.0 [ 12314524 ]
          Carl Steinbach made changes -
          Fix Version/s 0.3.0 [ 12313637 ]
          Carl Steinbach made changes -
          Summary Cannot create table with timestamp type column Add TIMESTAMP column type
          Issue Type Bug [ 1 ] New Feature [ 2 ]
          Shyam Sundar Sarkar made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Shyam Sundar Sarkar made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          Shyam Sundar Sarkar made changes -
          Attachment Hive-192.patch.txt [ 12452459 ]
          Carl Steinbach made changes -
          Link This issue is required by HIVE-1386 [ HIVE-1386 ]
          John Sichi made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Carl Steinbach made changes -
          Labels SQL
          Franklin Hu made changes -
          Summary Add TIMESTAMP column type Add TIMESTAMP column type for thrift dynamic_type
          Franklin Hu made changes -
          Link This issue relates to HIVE-1269 [ HIVE-1269 ]
          Ashutosh Chauhan made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 0.8.0 [ 12316178 ]
          Resolution Fixed [ 1 ]
          Carl Steinbach made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Carl Steinbach made changes -
          Summary Add TIMESTAMP column type for thrift dynamic_type DUPLICATE: Add TIMESTAMP column type for thrift dynamic_type

            People

            • Assignee:
              Shyam Sundar Sarkar
              Reporter:
              Johan Oskarsson
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development