Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-18966

LLAP should not shut down when some random thread goes down

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsAdd voteVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      LlapDaemonUncaughtExceptionHandler shuts down LLAP on any thread failure.
      Not sure it's the best idea... 3rd party libraries like permitted UDFs or Storage Handlers (e.g. Druid recently) can have errors that should not bring the entire daemon down.
      Perhaps we can go by thread name pattern?
      Overall logging the error, unless it's an OOM or other Error, might be better.

      We can also add error handling to important threads like schedulers, if it's missing, that will convert an exception into some critical one that will tell the handler to shut everything down.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned Assign to me
            sershe Sergey Shelukhin

            Dates

              Created:
              Updated:

              Slack

                Issue deployment