Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-19318 Improve Hive logging
  3. HIVE-18876

Remove Superfluous Logging in Driver

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.0.0
    • 4.0.0-alpha-1
    • HiveServer2

    Description

      https://github.com/apache/hive/blob/a4198f584aa0792a16d1e1eeb2ef3147403b8acb/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L2188-L2190

          if (console != null) {
            console.printInfo("OK");
          }
      
      1. Console can never be 'null'
      2. OK is not an informative logging message, and in the HiveServer2 logs, it is often interwoven into the logging and is pretty much useless on its own, without having to trace back through the logs to see what happened before it.  This is also printed out, even if an error occurred

      Please remove this block of code.

      Attachments

        1. HIVE-18876.1.patch
          0.8 kB
          Alice Fan
        2. HIVE-18876.2.patch
          0.8 kB
          Alice Fan

        Activity

          People

            afan Alice Fan
            belugabehr David Mollitor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: