Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0
    • Logical Optimizer
    • None

    Description

      As a result transforms a filter INPUT_FILE_NAME is not null; to false causing wrong results.

      Attachments

        1. HIVE-18660.patch
          5 kB
          Ashutosh Chauhan

        Activity

          hiveqa Hive QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
                Prechecks
          0 findbugs 0m 0s Findbugs executables are not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
                master Compile Tests
          +1 mvninstall 7m 15s master passed
          +1 compile 1m 1s master passed
          +1 checkstyle 0m 35s master passed
          +1 javadoc 0m 53s master passed
                Patch Compile Tests
          +1 mvninstall 1m 17s the patch passed
          +1 compile 0m 59s the patch passed
          +1 javac 0m 59s the patch passed
          +1 checkstyle 0m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 javadoc 0m 52s the patch passed
                Other Tests
          +1 asflicense 0m 12s The patch does not generate ASF License warnings.
          14m 5s



          Subsystem Report/Notes
          Optional Tests asflicense javac javadoc findbugs checkstyle compile
          uname Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux
          Build tool maven
          Personality /data/hiveptest/working/yetus/dev-support/hive-personality.sh
          git revision master / 89e75c7
          Default Java 1.8.0_111
          modules C: ql U: ql
          Console output http://104.198.109.242/logs//PreCommit-HIVE-Build-9135/yetus.txt
          Powered by Apache Yetus http://yetus.apache.org

          This message was automatically generated.

          hiveqa Hive QA added a comment - +1 overall Vote Subsystem Runtime Comment       Prechecks 0 findbugs 0m 0s Findbugs executables are not available. +1 @author 0m 0s The patch does not contain any @author tags.       master Compile Tests +1 mvninstall 7m 15s master passed +1 compile 1m 1s master passed +1 checkstyle 0m 35s master passed +1 javadoc 0m 53s master passed       Patch Compile Tests +1 mvninstall 1m 17s the patch passed +1 compile 0m 59s the patch passed +1 javac 0m 59s the patch passed +1 checkstyle 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 javadoc 0m 52s the patch passed       Other Tests +1 asflicense 0m 12s The patch does not generate ASF License warnings. 14m 5s Subsystem Report/Notes Optional Tests asflicense javac javadoc findbugs checkstyle compile uname Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux Build tool maven Personality /data/hiveptest/working/yetus/dev-support/hive-personality.sh git revision master / 89e75c7 Default Java 1.8.0_111 modules C: ql U: ql Console output http://104.198.109.242/logs//PreCommit-HIVE-Build-9135/yetus.txt Powered by Apache Yetus http://yetus.apache.org This message was automatically generated.
          hiveqa Hive QA added a comment -

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12909871/HIVE-18660.patch

          SUCCESS: +1 due to 1 test(s) being added or modified.

          ERROR: -1 due to 24 failed/errored test(s), 13151 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=241)
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
          org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl] (batchId=175)
          org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] (batchId=152)
          org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1] (batchId=172)
          org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=167)
          org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid] (batchId=171)
          org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=162)
          org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan] (batchId=164)
          org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=161)
          org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_opt_shuffle_serde] (batchId=180)
          org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] (batchId=122)
          org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1] (batchId=251)
          org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=222)
          org.apache.hadoop.hive.metastore.client.TestAddAlterDropIndexes.testDropIndexInvalidDB[Embedded] (batchId=206)
          org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoDbName[Embedded] (batchId=206)
          org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=257)
          org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
          org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testWriteSmallint (batchId=193)
          org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testWriteVarchar (batchId=193)
          org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=235)
          org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=235)
          org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=235)
          

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9135/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9135/console
          Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9135/

          Messages:

          Executing org.apache.hive.ptest.execution.TestCheckPhase
          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.YetusPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 24 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12909871 - PreCommit-HIVE-Build

          hiveqa Hive QA added a comment - Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12909871/HIVE-18660.patch SUCCESS: +1 due to 1 test(s) being added or modified. ERROR: -1 due to 24 failed/errored test(s), 13151 tests executed Failed tests: org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=241) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] (batchId=152) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1] (batchId=172) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=161) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_opt_shuffle_serde] (batchId=180) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] (batchId=122) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query1] (batchId=251) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=222) org.apache.hadoop.hive.metastore.client.TestAddAlterDropIndexes.testDropIndexInvalidDB[Embedded] (batchId=206) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoDbName[Embedded] (batchId=206) org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=257) org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188) org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testWriteSmallint (batchId=193) org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testWriteVarchar (batchId=193) org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=235) org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=235) org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=235) Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9135/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9135/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9135/ Messages: Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 24 tests failed This message is automatically generated. ATTACHMENT ID: 12909871 - PreCommit-HIVE-Build

          [~jcamachorodriguez] can you please review this?

          ashutoshc Ashutosh Chauhan added a comment - [~jcamachorodriguez] can you please review this?
          gopalv Gopal Vijayaraghavan added a comment - - edited

          Ashutosh Chauhan: the loop is better done as

          VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(colName.toUpperCase())
          

          (or added as a helper function like VirtualColumn::isVirtualColumnBasedOnAlias).

          LGTM, with that comment - +1

          gopalv Gopal Vijayaraghavan added a comment - - edited Ashutosh Chauhan : the loop is better done as VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(colName.toUpperCase()) (or added as a helper function like VirtualColumn::isVirtualColumnBasedOnAlias). LGTM, with that comment - +1

          +1

          jcamacho JesĂşs Camacho RodrĂ­guez added a comment - - edited +1

          Updated patch to do lookup in enum set instead of loop.

          Pushed to master.

          ashutoshc Ashutosh Chauhan added a comment - Updated patch to do lookup in enum set instead of loop. Pushed to master.

          This jira is resolved and released with Hive 3.0 If you find an issue with it, please create a new jira.

          ashutoshc Ashutosh Chauhan added a comment - This jira is resolved and released with Hive 3.0 If you find an issue with it, please create a new jira.

          People

            ashutoshc Ashutosh Chauhan Assign to me
            ashutoshc Ashutosh Chauhan
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack