[HIVE-18622] Vectorization: IF Statements, Comparisons, and more do not handle NULLs correctly

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: Hive
• Assignee: Matt McCline
• Reporter: Matt McCline
• Created: 05/Feb/18 09:21
• Updated: 22/May/18 23:16
• Resolved: 16/Feb/18 15:54

Description

 
Many vector expression classes are setting noNulls to true which does not work if the VRB is a scratch column being reused. The previous use may have set noNulls to false and the isNull array will have some rows marked as NULL. The result is wrong query results and sometimes NPEs (for BytesColumnVector).

So, many vector expressions need this:

      // Carefully handle NULLs...

      /*
       * For better performance on LONG/DOUBLE we don't want the conditional
       * statements inside the for loop.
       */
      outputColVector.noNulls = false;
 

And, vector expressions need to make sure the isNull array entry is set when outputColVector.noNulls is false.

And, all place that assign column value need to set noNulls to false when the value is NULL.

Almost all cases where noNulls is set to true are incorrect.

Issue Links

• is related to: HIVE-18593 NPE on vectorization group by
• is related to: HIVE-18529 Vectorization: Add a debug config option to disable scratch column reuse
• is related to: HIVE-19493 VectorUDFDateDiffColCol copySelected does not handle nulls correctly
• links to: RB #65592