Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-18221 test acid default
  3. HIVE-18377

avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Test, Transactions
    • None

    Description

      many UTs (e.g. TestHCatMultiOutputFormat, BeelineWithHS2ConnectionFileTestBase, TestOperationLoggingAPIWithMr, HCatBaseTest and many others)
      explicitly set hiveConf.set(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY.varname, "false");
      It would be better if they picked up the settings from data/conf/hive-site.xml.
      It adds consistency and makes it possible to run all tests with known config (at least approach this).

      The outline of the process is:
      1. build copies *-site.xml files from data/conf/**/*-site.xml to <module-name>target/testconf/
      2. HiveConf picks up target/testconf/hive-site.xml
      3. Various forms of *CliDriver may explicitly specify (e.g. MiniLlapLocalCliConfig) which hive-site.xml to use

      The first step is to see how many explicit settings of HIVE_SUPPORT_CONCURRENCY can be removed w/o breaking the tests.

      Attachments

        1. HIVE-18377.02.patch
          74 kB
          Eugene Koifman

        Activity

          People

            Unassigned Unassigned
            ekoifman Eugene Koifman
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: