[HIVE-18124] clean up isAcidTable() API vs isInsertOnlyTable()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Transactions
• Target Version/s: 3.0.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 22/Nov/17 00:47
• Updated: 01/Oct/19 22:07
• Resolved: 18/Dec/17 23:25

Description

With the addition of MM tables (AcidUtils.isInsertOnlyTable(table)) the methods in AcidUtils and dependent places are very muddled. There are now a number of places where we have something like isAcidTable = AcidUtils.isFullAcidTable(table) and a later getter
boolean isAcidTable() { return isAcidTable;}

Need to clean it up so that there is a isTransactional(Table) that checks transactional=true setting and isAcid(Table) to mean full ACID and isInsertOnly(Table) to mean MM tables.
This would accurately describe the semantics of the tables.

Issue Links

• is related to: HIVE-17671 TableScanDesc.isAcidTable is restricted to FullAcid tables
• relates to: HIVE-18155 HiveTxnManager.getWriteIdAndIncrement() referred to as statementId