Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-18110

OrcInputFormat.combineOrCreateETLStrategy() doesn't combine if there are deltas

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: Transactions
    • Labels:
      None
    • Target Version/s:

      Description

      this method has

          if (!deltas.isEmpty() || combinedCtx == null) {
            //why is this checking for deltas.isEmpty() - is this Acid 1.0 remnant?
            return new ETLSplitStrategy(
                context, fs, dir, files, readerTypes, isOriginal, deltas, covered, ugi,
                allowSyntheticFileIds, isDefaultFs);
          } else
      

      what is the purpose of checking deltas? (here with Acid 2.0 deltas is delete deltas)
      Is this some remnant of Acid 1.0?

      Also see TestInputOutputFormat.testEtlCombinedStrategy

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ekoifman Eugene Koifman
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: