[HIVE-17736] ObjectStore transaction handling can be simplified

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.0.0
• Component/s: Hive
• Assignee: Unassigned
• Reporter: Alex Kolbasov
• Created: 07/Oct/17 01:04
• Updated: 11/Oct/18 07:39

Description

There are many places in ObjectStore that do something like this:

    boolean commited = false;
   try {
      openTransaction();
      commited = commitTransaction();
    } finally {
      if (!commited) {
        rollbackTransaction();
      }
    }

We can simplify this in two ways:

1) Create a wrapper that calls given piece of code inside the block of code above. This is similar to TransactionManager in Sentry.

2) Create a special auto-closeable object that does the check and rollback on close.