Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-17284

remove OrcRecordUpdater.deleteEventIndexBuilder

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: Transactions
    • Labels:
      None
    • Target Version/s:

      Description

      There is no point in it. We know how many rows a delete_delta file has from ORC and they are all the same type - so no need for AcidStats.
      hive.acid.key.index has no value since delete_delta files are never split and are not likely to have more than 1 stripe since they are very small.

      Also can remove KeyIndexBuilder.acidStats - we only have 1 type of event per file

       

      if doing this, make sure to fix OrcInputFormat.isOriginal(Reader) and OrcInputFormat.isOriginal(Footer) etc

      there is new KeyIndexBuilder("delete") and new KeyIndexBuilder("insert"). The later is needed in HIVE-16812, the former can be removed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ekoifman Eugene Koifman
                Reporter:
                ekoifman Eugene Koifman
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: