[HIVE-17284] remove OrcRecordUpdater.deleteEventIndexBuilder

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 3.0.0
• Component/s: Transactions
• Target Version/s: 3.0.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 10/Aug/17 01:37
• Updated: 09/Jan/19 23:45
• Resolved: 09/Jan/19 23:45

Description

There is no point in it. We know how many rows a delete_delta file has from ORC and they are all the same type - so no need for AcidStats.
hive.acid.key.index has no value since delete_delta files are never split and are not likely to have more than 1 stripe since they are very small.

Also can remove KeyIndexBuilder.acidStats - we only have 1 type of event per file

 

if doing this, make sure to fix OrcInputFormat.isOriginal(Reader) and OrcInputFormat.isOriginal(Footer) etc

there is new KeyIndexBuilder("delete") and new KeyIndexBuilder("insert"). The later is needed in HIVE-16812, the former can be removed.

Issue Links

• is blocked by: HIVE-17089 make acid 2.0 the default
• is related to: HIVE-18662 hive.acid.key.index is missing entries
• relates to: HIVE-16812 VectorizedOrcAcidRowBatchReader doesn't filter delete events