Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-16945

Add method to compare Operators

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: Operators
    • Labels:
      None
    • Target Version/s:

      Description

      HIVE-10844 introduced a comparator factory class for operators that encapsulates all the logic to assess whether two operators are equal:
      https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/OperatorComparatorFactory.java

      The current design might create problems as any change in fields of operators will break the comparators. It would be better to do this via inheritance from Operator base class, by adding a logicalEquals(Operator other) method.

        Attachments

        1. HIVE-16945.3.patch
          55 kB
          Rui Li
        2. HIVE-16945.2.patch
          55 kB
          Rui Li
        3. HIVE-16945.1.patch
          55 kB
          Rui Li

          Issue Links

            Activity

              People

              • Assignee:
                lirui Rui Li
                Reporter:
                jcamachorodriguez Jesus Camacho Rodriguez
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: