Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-16866

existing available UDF is used in TestReplicationScenariosAcrossInstances#testDropFunctionIncrementalReplication

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.0.0
    • 3.0.0
    • HiveServer2
    • None

    Description

      use ivy://io.github.myui:hivemall:0.4.0-2 instead of ivy://com.yahoo.datasketches:sketches-hive:0.8.2
      in testDropFunctionIncrementalReplication

      Attachments

        1. HIVE-16866.1.patch
          15 kB
          Anishek Agarwal

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user anishek opened a pull request:

            https://github.com/apache/hive/pull/193

            HIVE-16866 : existing available UDF is used in TestReplicationScenariosAcrossInstances#testDropFunctionIncrementalReplication

            There are few javadoc changes and a method rename in repl change manager along with a few access modifiers as well.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/anishek/hive HIVE-16866

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/hive/pull/193.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #193


            commit e42d159bb8bc1ba9c0e91a7783452d13d858eaaa
            Author: Anishek Agarwal <anishek@gmail.com>
            Date: 2017-06-09T09:53:44Z

            HIVE-16866 : existing available UDF is used in TestReplicationScenariosAcrossInstances#testDropFunctionIncrementalReplication


            githubbot ASF GitHub Bot added a comment - GitHub user anishek opened a pull request: https://github.com/apache/hive/pull/193 HIVE-16866 : existing available UDF is used in TestReplicationScenariosAcrossInstances#testDropFunctionIncrementalReplication There are few javadoc changes and a method rename in repl change manager along with a few access modifiers as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anishek/hive HIVE-16866 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hive/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit e42d159bb8bc1ba9c0e91a7783452d13d858eaaa Author: Anishek Agarwal <anishek@gmail.com> Date: 2017-06-09T09:53:44Z HIVE-16866 : existing available UDF is used in TestReplicationScenariosAcrossInstances#testDropFunctionIncrementalReplication

            sankarh Please review the patch.

            anishek Anishek Agarwal added a comment - sankarh Please review the patch.

            anishek
            I posted few comments in the pull request. Pleas have a look.

            sankarh Sankar Hariappan added a comment - anishek I posted few comments in the pull request. Pleas have a look.

            sankarh provided responses in the pull request

            anishek Anishek Agarwal added a comment - sankarh provided responses in the pull request
            hiveqa Hive QA added a comment -

            Here are the results of testing the latest attachment:
            https://issues.apache.org/jira/secure/attachment/12872235/HIVE-16866.1.patch

            SUCCESS: +1 due to 2 test(s) being added or modified.

            ERROR: -1 due to 6 failed/errored test(s), 10810 tests executed
            Failed tests:

            org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite] (batchId=237)
            org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] (batchId=140)
            org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=232)
            org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=232)
            org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query78] (batchId=232)
            org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver (batchId=104)
            

            Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5600/testReport
            Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5600/console
            Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5600/

            Messages:

            Executing org.apache.hive.ptest.execution.TestCheckPhase
            Executing org.apache.hive.ptest.execution.PrepPhase
            Executing org.apache.hive.ptest.execution.ExecutionPhase
            Executing org.apache.hive.ptest.execution.ReportingPhase
            Tests exited with: TestsFailedException: 6 tests failed
            

            This message is automatically generated.

            ATTACHMENT ID: 12872235 - PreCommit-HIVE-Build

            hiveqa Hive QA added a comment - Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12872235/HIVE-16866.1.patch SUCCESS: +1 due to 2 test(s) being added or modified. ERROR: -1 due to 6 failed/errored test(s), 10810 tests executed Failed tests: org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite] (batchId=237) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] (batchId=140) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=232) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=232) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query78] (batchId=232) org.apache.hadoop.hive.cli.TestSparkCliDriver.org.apache.hadoop.hive.cli.TestSparkCliDriver (batchId=104) Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5600/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5600/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5600/ Messages: Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed This message is automatically generated. ATTACHMENT ID: 12872235 - PreCommit-HIVE-Build
            sankarh Sankar Hariappan added a comment - +1 cc thejas / sushanth
            thejas Thejas Nair added a comment -

            +1

            thejas Thejas Nair added a comment - +1
            thejas Thejas Nair added a comment -

            Test failures are unrelated. Committing shortly.

            thejas Thejas Nair added a comment - Test failures are unrelated. Committing shortly.
            thejas Thejas Nair added a comment -

            Test failures are unrelated.

            thejas Thejas Nair added a comment - Test failures are unrelated.
            thejas Thejas Nair added a comment -

            Committed to master.
            Thanks Anishek!

            thejas Thejas Nair added a comment - Committed to master. Thanks Anishek!

            Thanks sankarh / thejas for the review and commit.

            anishek Anishek Agarwal added a comment - Thanks sankarh / thejas for the review and commit.
            githubbot ASF GitHub Bot added a comment -

            Github user anishek closed the pull request at:

            https://github.com/apache/hive/pull/193

            githubbot ASF GitHub Bot added a comment - Github user anishek closed the pull request at: https://github.com/apache/hive/pull/193
            vgarg Vineet Garg added a comment -

            Hive 3.0.0 has been released so closing this jira.

            vgarg Vineet Garg added a comment - Hive 3.0.0 has been released so closing this jira.

            People

              anishek Anishek Agarwal
              anishek Anishek Agarwal
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: