[HIVE-16743] BitSet set() is incorrectly used in TxnUtils.createValidCompactTxnList()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Transactions
• Target Version/s: 3.0.0
• Assignee: Wei Zheng
• Reporter: Wei Zheng
• Created: 23/May/17 21:46
• Updated: 22/May/18 23:57
• Resolved: 24/May/17 17:59

Description

The second line is problematic

    BitSet bitSet = new BitSet(exceptions.length);
    bitSet.set(0, bitSet.length()); // for ValidCompactorTxnList, everything in exceptions are aborted

For example, exceptions' length is 2. We declare a BitSet object with initial size of 2 via the first line above. But that's not the actual size of the BitSet. So bitSet.length() will still return 0.

The intention of the second line above is to set all the bits to true. This was not achieved because bitSet.set(0, bitSet.length()) is equivalent to bitSet.set(0, 0).

Issue Links

• is related to: HIVE-16760 Update errata.txt for HIVE-16743
• relates to: HIVE-16753 Add tests that cover createValidReadTxnList and createValidCompactTxnList in TxnUtils.java
• relates to: HIVE-16534 Add capability to tell aborted transactions apart from open transactions in ValidTxnList