[HIVE-16693] beeline "source" command freezes if you have a comment in it?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Beeline
• Assignee: Ferdinand Xu
• Reporter: Carter Shanklin
• Created: 17/May/17 13:33
• Updated: 23/May/18 00:00
• Resolved: 22/May/17 05:52

Description

As far as I'm observing in my environment, which is HDP 2.6.1, version identified as 2.1.0.2.6.1.0-69 rc65de77a7cab18faf09a1f8e54c5ad5c44af8957

Call this file temp.sql:

-- comment
select 1;

Then in beeline run:

source temp.sql;

When I do this beeline freezes and must be killed.

The jstacks indicate a tight loop in org.apache.hive.beeline.Commands.sourceFileInternal:

main,org.apache.hive.beeline.Commands.sourceFileInternal(877)
main,org.apache.hive.beeline.Commands.sourceFile(860)
main,org.apache.hive.beeline.Commands.executeInternal(933)
main,org.apache.hive.beeline.Commands.execute(1161)
main,org.apache.hive.beeline.Commands.sql(1076)
main,org.apache.hive.beeline.BeeLine.dispatch(1145)

There's never any other active thread.

Looking at https://github.com/apache/hive/blob/455ffdd9125bdfe73b2c7f7ddebaeff138b77f53/beeline/src/java/org/apache/hive/beeline/Commands.java#L896

Don't you need to read the next line before you continue?

Issue Links

• relates to: HIVE-16695 beeline throws ArrayIndexOutOfBoundsException sourcing multiple multi-line queries