[HIVE-16443] HiveOperation doesn't have operations for Update, Delete, Merge

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.0.0
• Component/s: Query Planning, Transactions
• Assignee: Unassigned
• Reporter: Eugene Koifman
• Created: 13/Apr/17 22:57
• Updated: 28/Jul/21 14:13

Description

ideally it should have with proper privileges specified

SQLUPDATE("UPDATE", null, null, true, false),
SQLDELETE("DELETE", null, null, true, false),
SQLMERGE("MERGE", null, null, true, false);

It would also be useful to have INSERT and SELECT

all of these are currently QUERY is not informative

see how VIEW related stuff in SemanticAnalyzerFactory to set more specific operation type

SELECT can be determined by

private boolean isReadOnly(ASTNode ast) {
    if(ast == null) {
      return false;
    }
    if(ast.getType() == HiveParser.TOK_QUERY) {
      return isReadOnly((ASTNode) ast.getFirstChildWithType(HiveParser.TOK_INSERT));
    }
    if(ast.getType() == HiveParser.TOK_INSERT) {
      return isReadOnly((ASTNode)ast.getFirstChildWithType(HiveParser.TOK_DESTINATION));
    }
    if(ast.getType() == HiveParser.TOK_DESTINATION) {
      return null != ast.getFirstChildWithType(HiveParser.TOK_DIR);
    }
    return false;
  }

Issue Links

• is related to: HIVE-16447 QueryPlan.getOperation() is not always correct