Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-16181

Make logic for hdfs directory location extraction more generic, in webhcat test driver

Details

    • Test
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.3.0
    • WebHCat
    • None
    • Reviewed

    Description

      Patch to make regular expression for directory location lookup in setLocationPermGroup of TestDriverCurl more generic to accommodate patterns without port number like hdfs://mycluster/hive/warehouse/<db-name>

      Attachments

        1. HIVE-16181.1.patch
          0.6 kB
          Aswathy Chellammal Sreekumar

        Activity

          daijy Daniel Dai added a comment -

          Why not just remove ":\d+", seems to be a smaller change.

          daijy Daniel Dai added a comment - Why not just remove ":\d+", seems to be a smaller change.

          With that, the match is going all the way to last part of hdfs location, retrieving just the folder name instead of the whole path

          asreekumar Aswathy Chellammal Sreekumar added a comment - With that, the match is going all the way to last part of hdfs location, retrieving just the folder name instead of the whole path
          daijy Daniel Dai added a comment -

          I see. Patch looks good and committed to master. Thanks Aswathy!

          daijy Daniel Dai added a comment - I see. Patch looks good and committed to master. Thanks Aswathy!

          Thanks for the review daijy

          asreekumar Aswathy Chellammal Sreekumar added a comment - Thanks for the review daijy

          People

            asreekumar Aswathy Chellammal Sreekumar
            asreekumar Aswathy Chellammal Sreekumar
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: