Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-16166

HS2 may still waste up to 15% of memory on duplicate strings

Log workAgile BoardRank to TopRank to BottomVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None

      Description

      A heap dump obtained from one of our users shows that 15% of memory is wasted on duplicate strings, despite the recent optimizations that I made. The problematic strings just come from different sources this time. See the excerpt from the jxray (www.jxray.com) analysis attached.

      Adding String.intern() calls in the appropriate places reduces the overhead of duplicate strings with this workload to ~6%. The remaining duplicates come mostly from JDK internal and MapReduce data structures, and thus are more difficult to fix.

        Attachments

        1. ch_2_excerpt.txt
          5 kB
          Misha Dmitriev
        2. HIVE-16166.01.patch
          10 kB
          Misha Dmitriev
        3. HIVE-16166.02.patch
          11 kB
          Misha Dmitriev

        Issue Links

          Activity

          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

            • Assignee:
              misha@cloudera.com Misha Dmitriev Assign to me
              Reporter:
              misha@cloudera.com Misha Dmitriev

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment