[HIVE-15950] Make DbTxnManager use Metastore client consistently with callers

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.2.0
• Component/s: Transactions
• Target Version/s: 2.2.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 16/Feb/17 21:55
• Updated: 24/May/18 08:16
• Resolved: 17/Feb/17 17:33

Description

Currently it caches IMetastoreClient on init() but the same connection is indirectly saved using ThreadLocal (since Hive.get() uses ThreadLocal).
So it may cause something other than DbTxnManager to use the same connection. It needs to use the same Metastore client as the caller

Issue Links

• is related to: HIVE-19587 HeartBeat thread uses cancelled delegation token while connecting to meta on KERBEROS cluster
• supercedes: HIVE-15937 RetryingMetaStoreClient.invoke() should retry Trift exception even if not wrapped in MetaException