[HIVE-15048] Update/Delete statement using wrong WriteEntity when subqueries are involved

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 2.2.0
• Component/s: Transactions
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 25/Oct/16 01:28
• Updated: 01/Oct/19 22:07
• Resolved: 15/Dec/16 21:27

Description

See TestDbTxnManager2 for referenced methods

    checkCmdOnDriver(driver.run("create table target (a int, b int) " +
      "partitioned by (p int, q int) clustered by (a) into 2  buckets " +
      "stored as orc TBLPROPERTIES ('transactional'='true')"));
    checkCmdOnDriver(driver.run("create table source (a1 int, b1 int, p1 int, q1 int) clustered by (a1) into 2  buckets stored as orc TBLPROPERTIES ('transactional'='true')"));

    checkCmdOnDriver(driver.run("insert into target partition(p,q) values (1,2,1,2), (3,4,1,2), (5,6,1,3), (7,8,2,2)"));

    checkCmdOnDriver(driver.run(
      "update source set b1 = 1 where p1 in (select t.q from target t where t.p=2)"));

The last Update stmt creates the following Entity objects in the QueryPlan

inputs: [default@source, default@target, default@target@p=2/q=2]

outputs: [default@target@p=2/q=2]

Which is clearly wrong for outputs - the target table is not even partitioned(or called 'target').
This happens in UpdateDeleteSemanticAnalyzer.reparseAndSuperAnalyze()

I suspect
update T ... where T.p IN (select d from T where ...)
type query would also get messed up (but not necessarily fail) if T is partitioned and the subquery filters out some partitions but that does not mean that the same partitions are filtered out in the parent query.