[HIVE-14960] Improve the stability of TestNotificationListener

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.3.0
• Component/s: Test
• Assignee: Marta Kuczora
• Reporter: Marta Kuczora
• Created: 14/Oct/16 15:16
• Updated: 21/Jul/17 18:12
• Resolved: 12/Dec/16 14:24

Description

The TestNotificationListener.testAMQListener test case fails occasionally with the following error:

Error Message

expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
Stacktrace

java.lang.AssertionError: expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.apache.hive.hcatalog.listener.TestNotificationListener.tearDown(TestNotificationListener.java:114)

This error can happen if the testAMQListener method is completed before the last DROP_TABLE message got processed and put to the actualMessages list by the onMessage method. This can happen if there is a small delay in receiving the message, since the message receiving is not synchronized with the testAMQListener method.

Issue Links

• links to: Review