Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to IssueMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.1.0
    • 2.3.0
    • Parser
    • Incompatible change

    Description

      The main purpose for the configuration of HIVE_SUPPORT_SQL11_RESERVED_KEYWORDS is for backward compatibility because a lot of reserved key words has been used as identifiers in the previous releases. We already have had several releases with this configuration. Now when I tried to add new set operators to the parser, ANTLR is always complaining "code too large". I think it is time to remove this configuration. (1) It will simplify the parser logic and largely reduce the size of generated parser code; (2) it leave space for new features, especially those which require parser changes.

      Attachments

        1. HIVE-14872.02.patch
          104 kB
          Pengcheng Xiong
        2. HIVE-14872.01.patch
          3 kB
          Pengcheng Xiong

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            pxiong Pengcheng Xiong Assign to me
            pxiong Pengcheng Xiong
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment