[HIVE-14192] False positive error due to thrift

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0, 2.1.0
• Fix Version/s: 1.3.0, 2.1.1, 2.2.0
• Component/s: Metastore, Transactions
• Target Version/s: 1.3.0, 2.1.1
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 08/Jul/16 00:30
• Updated: 08/Dec/16 14:27
• Resolved: 09/Jul/16 03:22

Description

Given Thrift definition like this

struct LockComponent {
    1: required LockType type,
    2: required LockLevel level,
    3: required string dbname,
    4: optional string tablename,
    5: optional string partitionname,
    6: optional DataOperationType operationType = DataOperationType.UNSET,
    7: optional bool isAcid = false
}

The generated LockComponent has

  public LockComponent() {
    this.operationType = org.apache.hadoop.hive.metastore.api.DataOperationType.UNSET;

    this.isAcid = false;

  }
  public boolean isSetOperationType() {
    return this.operationType != null;
  }
  public boolean isSetIsAcid() {
    return EncodingUtils.testBit(__isset_bitfield, __ISACID_ISSET_ID);
  }

So bottom line is even if LockComponent is created by old version of the client which doesn't have operationType filed, isSetOperationType() will still return true on the server.

This causes a false positive exception in TxnHandler.enqueueLockWithRetry() during Rolling Upgrade scenarios.