Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.0
    • Fix Version/s: 0.6.0
    • Component/s: HBase Handler
    • Labels:
      None

      Description

      Disabling WAL can lead to much better INSERT performance in cases where other means of safe recovery (such as bulk import) are available.

      1. HIVE-1383.4.patch
        23 kB
        John Sichi
      2. HIVE-1383.3.patch
        22 kB
        John Sichi
      3. HIVE-1383.2.patch
        21 kB
        John Sichi
      4. HIVE-1383.1.patch
        3 kB
        John Sichi

        Issue Links

          Activity

          Hide
          Ning Zhang added a comment -

          Committed. Thanks John!

          Show
          Ning Zhang added a comment - Committed. Thanks John!
          Hide
          Ning Zhang added a comment -

          +1. Will commit if tests pass.

          Show
          Ning Zhang added a comment - +1. Will commit if tests pass.
          Hide
          John Sichi added a comment -

          Ning, can you take a look at this one?

          Show
          John Sichi added a comment - Ning, can you take a look at this one?
          Hide
          John Sichi added a comment -

          New patch with HiveConf changes.

          Show
          John Sichi added a comment - New patch with HiveConf changes.
          Hide
          Ning Zhang added a comment -

          Looks good in general, except one nitpick: should we move HBASE_WAL_ENABLED = "hive.hbase.wal.enabled" to HiveConf.java and add an entry to hive-default.xml? It would be easier for users to browse all hive settings and their default values from a centralized conf file.

          Show
          Ning Zhang added a comment - Looks good in general, except one nitpick: should we move HBASE_WAL_ENABLED = "hive.hbase.wal.enabled" to HiveConf.java and add an entry to hive-default.xml? It would be easier for users to browse all hive settings and their default values from a centralized conf file.
          Hide
          Ning Zhang added a comment -

          I will take a look.

          Show
          Ning Zhang added a comment - I will take a look.
          Hide
          John Sichi added a comment -

          Latest patch is rebased against the commit for HIVE-1228.

          Show
          John Sichi added a comment - Latest patch is rebased against the commit for HIVE-1228 .
          Hide
          John Sichi added a comment -

          Just noticed that my testcase here conflicts with the one I added in HIVE-1228; I'll update it after HIVE-1228 gets committed.

          Show
          John Sichi added a comment - Just noticed that my testcase here conflicts with the one I added in HIVE-1228 ; I'll update it after HIVE-1228 gets committed.
          Hide
          John Sichi added a comment -

          Added a testcase.

          Show
          John Sichi added a comment - Added a testcase.
          Hide
          John Sichi added a comment -

          To remove a link, click on the "Issue Links:" over to the left of the links; from there you can delete them.

          Show
          John Sichi added a comment - To remove a link, click on the "Issue Links:" over to the left of the links; from there you can delete them.
          Hide
          Jeff Hammerbacher added a comment -

          Ignore the link to HBASE-1932--was a typo. Sorry about that, can't remove links.

          Show
          Jeff Hammerbacher added a comment - Ignore the link to HBASE-1932 --was a typo. Sorry about that, can't remove links.
          Hide
          John Sichi added a comment -

          Need to add a test; I'm just stashing this preliminary patch here so I don't lose it.

          Show
          John Sichi added a comment - Need to add a test; I'm just stashing this preliminary patch here so I don't lose it.

            People

            • Assignee:
              John Sichi
              Reporter:
              John Sichi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development