[HIVE-13415] Decouple Sessions from thrift binary transport

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 2.1.0
• Component/s: HiveServer2
• Hadoop Flags: Reviewed
• Assignee: Rajat Khandelwal
• Reporter: Rajat Khandelwal
• Created: 04/Apr/16 09:15
• Updated: 28/Mar/17 16:32
• Resolved: 15/Apr/16 11:50

Description

Current behaviour is:

• Open a thrift binary transport
• create a session
• close the transport

Then the session gets closed. Consequently, all the operations running in the session also get killed.

Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed.

This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this.

The issue that introduced it is HIVE-9601 Relevant discussions at here, here and mentioned links on those comments.

Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService:

server.setServerEventHandler(serverEventHandler);

Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns.

Issue Links

• blocks: LENS-518 Move Hive dependency to Apache Hive
• is depended upon by: LENS-1150 HiveDriver should create sessions independent of the transport
• is related to: HIVE-14227 Investigate invalid SessionHandle and invalid OperationHandle
• relates to: HIVE-9601 New Beeline queries will hang If Beeline terminates in-properly [Spark Branch]