[HIVE-13220] Set isNull[i] = false for non-null decimal values in DecimalColumnVector

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.1.0
• Target Version/s: 2.1.2, 3.0.0
• Assignee: Prasanth Jayachandran
• Reporter: Prasanth Jayachandran
• Created: 07/Mar/16 20:03
• Updated: 27/Feb/24 22:23

Description

When fixing HIVE-13083 noticed that for non-null decimal values, set function does not update the isNull state (isNull[i] should be set to false). Updating this state in DecimalColumnVector breaks all decimal vector filter expressions as the filter expression can change state on it's own.

        System.arraycopy(inputIsNull, 0, outputIsNull, 0, n);
        for(int i = 0; i != n; i++) {

          // The following may override a "false" null setting if an error or overflow occurs.
          DecimalUtil.addChecked(i, vector[i], value, outputColVector);
        }

Issue Links

• depends upon: HIVE-13083 Writing HiveDecimal to ORC can wrongly suppress present stream
• is related to: HIVE-12750 Vectorization logic not maintaining noNulls flag and isNull array properly causing wrong query results