Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-12768

Thread safety: binary sortable serde decimal deserialization

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Labels:
      None
    • Target Version/s:

      Description

      We see thread safety issues due to static decimal buffer in binary sortable serde.

      1. HIVE-12768.1.patch
        0.9 kB
        Vikram Dixit K

        Issue Links

          Activity

          Hide
          hiveqa Hive QA added a comment -

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12780077/HIVE-12768.1.patch

          ERROR: -1 due to no test(s) being added or modified.

          ERROR: -1 due to 19 failed/errored test(s), 9994 tests executed
          Failed tests:

          TestHWISessionManager - did not produce a TEST-*.xml file
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_2
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_order2
          org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_dynamic
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_columnstats_partlvl_multiple_part_clause
          org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testMultiSessionMultipleUse
          org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testSingleSessionMultipleUse
          org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveOperationType.checkHiveOperationTypeMatch
          org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarDataNucleusUnCaching
          org.apache.hive.jdbc.TestSSL.testSSLVersion
          org.apache.hive.spark.client.TestSparkClient.testAddJarsAndFiles
          org.apache.hive.spark.client.TestSparkClient.testCounters
          org.apache.hive.spark.client.TestSparkClient.testErrorJob
          org.apache.hive.spark.client.TestSparkClient.testJobSubmission
          org.apache.hive.spark.client.TestSparkClient.testMetricsCollection
          org.apache.hive.spark.client.TestSparkClient.testRemoteClient
          org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob
          org.apache.hive.spark.client.TestSparkClient.testSyncRpc
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6509/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6509/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6509/

          Messages:

          Executing org.apache.hive.ptest.execution.TestCheckPhase
          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 19 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12780077 - PreCommit-HIVE-TRUNK-Build

          Show
          hiveqa Hive QA added a comment - Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12780077/HIVE-12768.1.patch ERROR: -1 due to no test(s) being added or modified. ERROR: -1 due to 19 failed/errored test(s), 9994 tests executed Failed tests: TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_order2 org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_dynamic org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_columnstats_partlvl_multiple_part_clause org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testMultiSessionMultipleUse org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testSingleSessionMultipleUse org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveOperationType.checkHiveOperationTypeMatch org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarDataNucleusUnCaching org.apache.hive.jdbc.TestSSL.testSSLVersion org.apache.hive.spark.client.TestSparkClient.testAddJarsAndFiles org.apache.hive.spark.client.TestSparkClient.testCounters org.apache.hive.spark.client.TestSparkClient.testErrorJob org.apache.hive.spark.client.TestSparkClient.testJobSubmission org.apache.hive.spark.client.TestSparkClient.testMetricsCollection org.apache.hive.spark.client.TestSparkClient.testRemoteClient org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob org.apache.hive.spark.client.TestSparkClient.testSyncRpc Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6509/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6509/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6509/ Messages: Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 19 tests failed This message is automatically generated. ATTACHMENT ID: 12780077 - PreCommit-HIVE-TRUNK-Build
          Hide
          hagleitn Gunther Hagleitner added a comment -

          +1 LGTM. Would be nice to include unit test.

          Show
          hagleitn Gunther Hagleitner added a comment - +1 LGTM. Would be nice to include unit test.
          Hide
          sershe Sergey Shelukhin added a comment -

          +1. Should this be committed?

          Show
          sershe Sergey Shelukhin added a comment - +1. Should this be committed?
          Hide
          sershe Sergey Shelukhin added a comment -

          Committed to master and branch-2.0.

          Show
          sershe Sergey Shelukhin added a comment - Committed to master and branch-2.0.

            People

            • Assignee:
              vikram.dixit Vikram Dixit K
              Reporter:
              vikram.dixit Vikram Dixit K
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development