Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-12409

make sure SessionState.initTxnMgr() is thread safe

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.3.0
    • Component/s: HiveServer2, Transactions
    • Labels:
      None
    • Target Version/s:

      Description

      make this method synchronized since HS2 may run multiple threads in a Session. see HIVE-11402

      1. HIVE-12409.patch
        0.7 kB
        Eugene Koifman

        Issue Links

          Activity

          Hide
          ekoifman Eugene Koifman added a comment -

          Jason Dere could you review?

          Show
          ekoifman Eugene Koifman added a comment - Jason Dere could you review?
          Hide
          jdere Jason Dere added a comment -

          +1

          Show
          jdere Jason Dere added a comment - +1
          Hide
          hiveqa Hive QA added a comment -

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12772274/HIVE-12409.patch

          ERROR: -1 due to no test(s) being added or modified.

          ERROR: -1 due to 6 failed/errored test(s), 9845 tests executed
          Failed tests:

          TestHWISessionManager - did not produce a TEST-*.xml file
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_histogram_numeric
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
          org.apache.hive.jdbc.TestSSL.testSSLVersion
          org.apache.hive.jdbc.miniHS2.TestHs2Metrics.testMetrics
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6066/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6066/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6066/

          Messages:

          Executing org.apache.hive.ptest.execution.TestCheckPhase
          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 6 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12772274 - PreCommit-HIVE-TRUNK-Build

          Show
          hiveqa Hive QA added a comment - Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12772274/HIVE-12409.patch ERROR: -1 due to no test(s) being added or modified. ERROR: -1 due to 6 failed/errored test(s), 9845 tests executed Failed tests: TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_histogram_numeric org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hive.jdbc.TestSSL.testSSLVersion org.apache.hive.jdbc.miniHS2.TestHs2Metrics.testMetrics Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6066/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6066/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6066/ Messages: Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed This message is automatically generated. ATTACHMENT ID: 12772274 - PreCommit-HIVE-TRUNK-Build
          Hide
          ekoifman Eugene Koifman added a comment -

          committed to branch-1 and master
          thanks Jason Dere for review

          Show
          ekoifman Eugene Koifman added a comment - committed to branch-1 and master thanks Jason Dere for review

            People

            • Assignee:
              ekoifman Eugene Koifman
              Reporter:
              ekoifman Eugene Koifman
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development