Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • llap
    • None
    • None

    Description

      Looking through the changes for ORC, there are methods being added without documentation:

      --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
      +++ ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
      @@ -360,8 +353,18 @@ RecordReader rows(long offset, long length,
      
         MetadataReader metadata() throws IOException;
      
      +  List<Integer> getVersionList();
      +
      +  int getMetadataSize();
      +
      +  List<OrcProto.StripeStatistics> getOrcProtoStripeStatistics();
      +
      +  List<StripeStatistics> getStripeStatistics();
      +
      +  List<OrcProto.ColumnStatistics> getOrcProtoFileStatistics();
      +
      +  DataReader createDefaultDataReader(boolean useZeroCopy);
      +
      

      You really need to look through all of the interfaces and fix them before merging into master.

      Attachments

        Activity

          People

            sershe Sergey Shelukhin
            omalley Owen O'Malley
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: