Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-11278

Partition.setOutputFormatClass should not do toString for Class object

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • None
    • None
    • Reviewed

    Description

      https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java#L286

      inside setInputFormatClass, we're doing:

       public void setInputFormatClass(Class<? extends InputFormat> inputFormatClass) {
          this.inputFormatClass = inputFormatClass;
          tPartition.getSd().setInputFormat(inputFormatClass.getName());
        }
      

      But inside setOutputFormatClass, we're doing toString for class, instead of getName().

        public void setOutputFormatClass(Class<? extends HiveOutputFormat> outputFormatClass) {
          this.outputFormatClass = outputFormatClass;
          tPartition.getSd().setOutputFormat(HiveFileFormatUtils
              .getOutputFormatSubstitute(outputFormatClass).toString());
        }
      

      Difference is that, for Class A.class, toString is "class A.class", getName is "A.class". So Class.forName(cls.getName()) succeeds, but Class.forName(cls.toString()) is not valid.

      So if you get a partition, set outputformat, and make an alter call, then get the partition again and make a getOutputFormatClass call on that object, it throws a ClassNotFoundException on https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java#L316, because it's basically calling Class.forName("class a.b.c.ClassName.class") which is wrong!

      Attachments

        1. HIVE-11278.01.patch
          0.8 kB
          Rajat Khandelwal

        Issue Links

          Activity

            People

              prongs Rajat Khandelwal
              prongs Rajat Khandelwal
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: