Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-10768

In QTestGenTask.execute() we should not throw an exception right away if we are unable to clean any old files

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.2.1
    • Testing Infrastructure
    • None

    Description

      Currently in QTestGenTask.execute(), we have code like :

             if (logFile != null) {
               File lf = new File(logFile);
               if (lf.exists()) {
                 if (!lf.delete()) {
                   throw new Exception("Could not delete log file " + lf.getCanonicalPath());
               }
      

      If the log file gets locked due to some other process, it throws the above exception and short circuits the entire test suite. We should provide a mechanism to generate alternative new log files/temporary files whenever possible to avoid unit test failures.

      Attachments

        1. HIVE-10768.1.patch
          3 kB
          Hari Sankar Sivarama Subramaniyan
        2. HIVE-10768.2.patch
          3 kB
          Hari Sankar Sivarama Subramaniyan
        3. HIVE-10768.3.patch
          3 kB
          Hari Sankar Sivarama Subramaniyan

        Issue Links

          Activity

            People

              hsubramaniyan Hari Sankar Sivarama Subramaniyan
              hsubramaniyan Hari Sankar Sivarama Subramaniyan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: