Hive
  1. Hive
  2. HIVE-1069

CREATE VIEW followup: find and document current expected version of thrift, and regenerate code to match

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.0
    • Fix Version/s: 0.6.0
    • Component/s: Metastore
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      For HIVE-972, I used a slightly different version of thrift from the last one used. This task involves finding the correct version (from Raghu or Ning), adding info about it to the Hive developer wiki page, and regenerating thrift files to match. As part of this, also test view support with remote metastore.

        Issue Links

          Activity

          Hide
          John Sichi added a comment -

          Added Raghu and Ning as watchers in case they know...for the last patch, I used the archived r760184 version of thrift linked at http://developers.facebook.com/thrift. What is the correct version to be using?

          Show
          John Sichi added a comment - Added Raghu and Ning as watchers in case they know...for the last patch, I used the archived r760184 version of thrift linked at http://developers.facebook.com/thrift . What is the correct version to be using?
          Hide
          John Sichi added a comment -
          Show
          John Sichi added a comment - I have written up the instructions here: http://wiki.apache.org/hadoop/Hive/HowToContribute#Generating_Code
          Hide
          John Sichi added a comment -

          This patch eliminates the inconsistencies I introduced in the generated files when I used the incorrect version of thrift for HIVE-972.

          Show
          John Sichi added a comment - This patch eliminates the inconsistencies I introduced in the generated files when I used the incorrect version of thrift for HIVE-972 .
          Hide
          Namit Jain added a comment -

          +1

          will commit if the tests pass

          Show
          Namit Jain added a comment - +1 will commit if the tests pass
          Hide
          Namit Jain added a comment -

          Committed. Thanks John

          Show
          Namit Jain added a comment - Committed. Thanks John

            People

            • Assignee:
              John Sichi
              Reporter:
              John Sichi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development