[HIVE-10582] variable typo in HiveOpConverter (714) and SemanticAnalyzer (7496)

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Pending Closed
• Fix Version/s: 1.3.0
• Component/s: Query Planning
• Assignee: Alexander Pivovarov
• Reporter: Alexander Pivovarov
• Created: 02/May/15 07:26
• Updated: 29/Dec/16 20:57
• Resolved: 13/May/15 19:01

Description

HiveOpConverter lines 703-717

      int kindex = exprBack == null ? -1 : ExprNodeDescUtils.indexOf(exprBack, reduceKeysBack);
      if (kindex >= 0) {
        ColumnInfo newColInfo = new ColumnInfo(colInfo);
        newColInfo.setInternalName(Utilities.ReduceField.KEY + ".reducesinkkey" + kindex);
        newColInfo.setAlias(outputColName);
        newColInfo.setTabAlias(colInfo.getTabAlias());
        outputColumns.add(newColInfo);
        index[i] = kindex;
        continue;
      }
      int vindex = exprBack == null ? -1 : ExprNodeDescUtils.indexOf(exprBack, reduceValuesBack);
      if (kindex >= 0) { // looks like it should be vindex instead of kindex
        index[i] = -vindex - 1;
        continue;
      }

Most probably the second "if (kindex >= 0)" (line 714) should be replaces with "if (vindex >= 0)"

The same situation in SemanticAnalyzer (7483-7499)

      int kindex = exprBack == null ? -1 : ExprNodeDescUtils.indexOf(exprBack, reduceKeysBack);
      if (kindex >= 0) {
        ColumnInfo newColInfo = new ColumnInfo(colInfo);
        newColInfo.setInternalName(Utilities.ReduceField.KEY + ".reducesinkkey" + kindex);
        newColInfo.setTabAlias(nm[0]);
        outputRR.put(nm[0], nm[1], newColInfo);
        if (nm2 != null) {
          outputRR.addMappingOnly(nm2[0], nm2[1], newColInfo);
        }
        index[i] = kindex;
        continue;
      }
      int vindex = exprBack == null ? -1 : ExprNodeDescUtils.indexOf(exprBack, reduceValuesBack);
      if (kindex >= 0) { // looks like it should be vindex instead of kindex
        index[i] = -vindex - 1;
        continue;
      }

Issue Links

• is related to: HIVE-15524 Wrong result for LEFT outer join in Tez using MapJoinOperator
• links to: https://reviews.apache.org/r/33790/