[HIVE-10249] ACID: show locks should show who the lock is waiting for

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.3.0, 2.1.0
• Component/s: Transactions
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 08/Apr/15 00:37
• Updated: 21/Jun/16 15:53
• Resolved: 30/Mar/16 19:22

Description

instead of just showing state WAITING, we should include what the lock is waiting for. It will make diagnostics easier.

It would also be useful to add QueryPlan.getQueryId() so it's easy to see which query the lock belongs to.

1. need to store this in HIVE_LOCKS (additional field); this has a perf hit to do another update on failed attempt and to clear filed on successful attempt. (Actually on success, we update anyway). How exactly would this be displayed? Each lock can block but we acquire all parts of external lock at once. Since we stop at first one that blocked, we’d only update that one…
2. This needs a matching Thrift change to pass to client: ShowLocksResponse
3. Perhaps we can start updating this info after lock was in W state for some time to reduce perf hit.
4. This is mostly useful for “Why is my query stuck”

Issue Links

• depends upon: HIVE-12832 RDBMS schema changes for HIVE-11388
• relates to: HIVE-11793 SHOW LOCKS with DbTxnManager ignores filter options

Sub-Tasks

• Thrift and RDBMS changes for HIVE-10249: Resolved