[HELIX-476] ZNRecordStreamingSerializer.deserialize throw NullPointerException when 'id' property is not the first item in JSON

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.6.3
• Fix Version/s: 0.7.1, 0.6.4
• Component/s: helix-core
• Assignee: Unassigned
• Reporter: Flier Lu
• Created: 22/Jul/14 03:34
• Updated: 25/Aug/14 17:32
• Resolved: 22/Jul/14 04:28

Description

ZNRecordStreamingSerializer.deserialize create ZNRecord when found 'id' property, but if 'id' is not the first item in JSON (from python etc), the record will be null and throw NullPointerException when parse another property.

while (jp.nextToken() != JsonToken.END_OBJECT) {
String fieldname = jp.getCurrentName();
jp.nextToken(); // move to value, or START_OBJECT/START_ARRAY
if ("id".equals(fieldname))

{ // contains an object record = new ZNRecord(jp.getText()); // CREATE ZNRecord }

else if ("simpleFields".equals(fieldname)) {
while (jp.nextToken() != JsonToken.END_OBJECT)

{ String key = jp.getCurrentName(); jp.nextToken(); // move to value record.setSimpleField(key, jp.getText()); // CRASH }

we need cached those property before we meet the 'id' property