[HELIX-121] Possible race condition in ZkHelixManager.disconnect() during zk session expiry

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Sprint: Sprint #4 10/2 - 10/16
• Assignee: Zhen Zhang
• Reporter: Zhen Zhang
• Created: 05/Jun/13 06:06
• Updated: 15/Jul/14 22:06

Description

There is race condition in ZkHelixManager.disconnect() during zk session expiry. If someone calls ZkHelixManager.disconnect() when zk session expiry happens, the real shutdown work may be skipped:

public void disconnect()
{
if (!isConnected())

{ logger.error("ClusterManager " + _instanceName + " already disconnected"); return; }

disconnectInternal();
}

And when zk connection comes back again, the zk manager instance will come alive again even though the instance might be considered dead already.