Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9951

Use string constants for XML tags in OfflineImageReconstructor

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Tags:
      tools

      Description

      In class OfflineImageReconstructor, it uses many SectionProcessors to process xml files and load the subtree of the XML into a Node structure. But there are lots of places that node removes key by directively writing value in methods rather than define them first. Like this:

      Node expiration = directive.removeChild("expiration");
      

      We could improve this to define them in Node and them invoked like this way:

      Node expiration=directive.removeChild(Node.CACHE_MANAGER_SECTION_EXPIRATION);
      

      And it will be good to manager node key's name in the future.

      1. HDFS-9551.001.patch
        42 kB
        Yiqun Lin
      2. HDFS-9551.002.patch
        76 kB
        Yiqun Lin
      3. HDFS-9551.003.patch
        74 kB
        Yiqun Lin
      4. HDFS-9551.004.patch
        74 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Colin P. McCabe for commit!

        Show
        linyiqun Yiqun Lin added a comment - Thanks Colin P. McCabe for commit!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9483 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9483/)
        HDFS-9951. Use string constants for XML tags in (cmccabe: rev 680716f31e120f4d3ee70b095e4db46c05b891d9)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9483 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9483/ ) HDFS-9951 . Use string constants for XML tags in (cmccabe: rev 680716f31e120f4d3ee70b095e4db46c05b891d9) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        Hide
        cmccabe Colin P. McCabe added a comment -

        Committed to 2.8

        Show
        cmccabe Colin P. McCabe added a comment - Committed to 2.8
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks for fixing the patch. +1

        Show
        cmccabe Colin P. McCabe added a comment - Thanks for fixing the patch. +1
        Hide
        linyiqun Yiqun Lin added a comment -

        The remained failed unit tests look not related.

        Show
        linyiqun Yiqun Lin added a comment - The remained failed unit tests look not related.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 46s trunk passed
        +1 compile 0m 42s trunk passed with JDK v1.8.0_74
        +1 compile 0m 41s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 52s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_74
        +1 javac 0m 38s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_95
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 21 unchanged - 3 fixed = 21 total (was 24)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 1m 1s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95
        -1 unit 72m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 70m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        168m 40s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.datanode.TestDataNodeLifeline
          hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794300/HDFS-9551.004.patch
        JIRA Issue HDFS-9951
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6fe24e6daf32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 33239c9
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14873/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14873/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 46s trunk passed +1 compile 0m 42s trunk passed with JDK v1.8.0_74 +1 compile 0m 41s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_74 +1 javac 0m 38s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_95 +1 javac 0m 41s the patch passed +1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 21 unchanged - 3 fixed = 21 total (was 24) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95 -1 unit 72m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 70m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 168m 40s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794300/HDFS-9551.004.patch JIRA Issue HDFS-9951 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6fe24e6daf32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 33239c9 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14873/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14873/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14873/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Sorry for Colin P. McCabe, I tested in my local. There was a actual error. I replaced the xttr to xttrs.

        Node xattr = xattrs.removeChild("xattr");
        Node xattr = xattrs.removeChild(INODE_SECTION_XATTRS);
        

        Update the latest patch to fixing this error and fixing the remained checkstyle issues.

        Show
        linyiqun Yiqun Lin added a comment - Sorry for Colin P. McCabe , I tested in my local. There was a actual error. I replaced the xttr to xttrs . Node xattr = xattrs.removeChild( "xattr" ); Node xattr = xattrs.removeChild(INODE_SECTION_XATTRS); Update the latest patch to fixing this error and fixing the remained checkstyle issues.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Please run the test on your local computer and examine the log file.

        Show
        cmccabe Colin P. McCabe added a comment - Please run the test on your local computer and examine the log file.
        Hide
        linyiqun Yiqun Lin added a comment -

        I have looked the log, the test TestOfflineImageViewer was a timed out junit test not failed. And the jekins log only shows the failed tests reason, like these:

        {coed}

        Failed tests:
        TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime:256 Expect metrics to count no lifeline calls. expected:<0> but was:<1>

        Tests in error:
        TestHFlush.testHFlushInterrupted ? ClosedByInterrupt

        Tests run: 4319, Failures: 1, Errors: 1, Skipped: 17

        And the test for {{TestOfflineImageViewer}} looks good:
        

        Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
        Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.41 sec - in org.apache.hadoop.hdfs.tools.TestDFSAdmin
        Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
        Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.395 sec - in org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr
        Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
        Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.753 sec - in org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks
        Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary
        Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl

        
        

        Is this means this test was tested ok?

        Show
        linyiqun Yiqun Lin added a comment - I have looked the log, the test TestOfflineImageViewer was a timed out junit test not failed. And the jekins log only shows the failed tests reason, like these: {coed} Failed tests: TestDataNodeLifeline.testNoLifelineSentIfHeartbeatsOnTime:256 Expect metrics to count no lifeline calls. expected:<0> but was:<1> Tests in error: TestHFlush.testHFlushInterrupted ? ClosedByInterrupt Tests run: 4319, Failures: 1, Errors: 1, Skipped: 17 And the test for {{TestOfflineImageViewer}} looks good: Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.41 sec - in org.apache.hadoop.hdfs.tools.TestDFSAdmin Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.395 sec - in org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForXAttr Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.753 sec - in org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary Running org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl Is this means this test was tested ok?
        Hide
        cmccabe Colin P. McCabe added a comment -

        Hi Yiqun Lin, have you looked at the log to see why the unit test is failing?

        Show
        cmccabe Colin P. McCabe added a comment - Hi Yiqun Lin , have you looked at the log to see why the unit test is failing?
        Hide
        linyiqun Yiqun Lin added a comment -

        The failed unit test org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer is mostly because test method TestOfflineImageViewer#testReverseXmlRoundTrip. And this failed test has already happened after patch 001. It looks strange that the patch 001 was just replacing tags to string constants and I have a concretely check, there was no other operations. So what do you think, Colin P. McCabe.

        Show
        linyiqun Yiqun Lin added a comment - The failed unit test org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer is mostly because test method TestOfflineImageViewer#testReverseXmlRoundTrip . And this failed test has already happened after patch 001. It looks strange that the patch 001 was just replacing tags to string constants and I have a concretely check, there was no other operations. So what do you think, Colin P. McCabe .
        Hide
        cmccabe Colin P. McCabe added a comment -

        unit test failures are related

        Show
        cmccabe Colin P. McCabe added a comment - unit test failures are related
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 15s trunk passed
        +1 compile 0m 46s trunk passed with JDK v1.8.0_74
        +1 compile 0m 43s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 1m 12s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 54s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.8.0_74
        +1 javac 0m 37s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_95
        +1 javac 0m 41s the patch passed
        -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 4 new + 21 unchanged - 3 fixed = 25 total (was 24)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 21s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 51s the patch passed with JDK v1.7.0_95
        -1 unit 60m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 55m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        142m 13s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestErasureCodeBenchmarkThroughput
          hadoop.hdfs.server.blockmanagement.TestBlockManager
        JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline
          hadoop.hdfs.TestHFlush
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793701/HDFS-9551.003.patch
        JIRA Issue HDFS-9951
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 652f5d027049 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3ef5500
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14833/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14833/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 15s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_74 +1 compile 0m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 54s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_74 +1 javac 0m 37s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_95 +1 javac 0m 41s the patch passed -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 4 new + 21 unchanged - 3 fixed = 25 total (was 24) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 51s the patch passed with JDK v1.7.0_95 -1 unit 60m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 55m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 142m 13s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.server.blockmanagement.TestBlockManager JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestHFlush JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793701/HDFS-9551.003.patch JIRA Issue HDFS-9951 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 652f5d027049 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3ef5500 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14833/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14833/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14833/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Update the latest patch for addressing the comments and fixing the checkstyle issues.

        Show
        linyiqun Yiqun Lin added a comment - Update the latest patch for addressing the comments and fixing the checkstyle issues.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks for working on this. Can you put the string constants into PBImageXmlWriter.java? OfflineImageReconstructor#Node is not a public class.

        Show
        cmccabe Colin P. McCabe added a comment - Thanks for working on this. Can you put the string constants into PBImageXmlWriter.java ? OfflineImageReconstructor#Node is not a public class.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 41s trunk passed
        +1 compile 0m 41s trunk passed with JDK v1.8.0_74
        +1 compile 0m 39s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 49s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 47s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_74
        +1 javac 0m 38s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.7.0_95
        +1 javac 0m 38s the patch passed
        -1 checkstyle 0m 20s hadoop-hdfs-project/hadoop-hdfs: patch generated 14 new + 21 unchanged - 3 fixed = 35 total (was 24)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 10s the patch passed
        +1 javadoc 1m 5s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
        -1 unit 57m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 56m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        139m 3s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
        JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793478/HDFS-9551.002.patch
        JIRA Issue HDFS-9951
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 40ee85cfcefd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / eba66a6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14821/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14821/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_74 +1 compile 0m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 47s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 47s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_74 +1 javac 0m 38s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed -1 checkstyle 0m 20s hadoop-hdfs-project/hadoop-hdfs: patch generated 14 new + 21 unchanged - 3 fixed = 35 total (was 24) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 -1 unit 57m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 56m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 139m 3s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793478/HDFS-9551.002.patch JIRA Issue HDFS-9951 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 40ee85cfcefd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eba66a6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14821/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14821/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14821/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Colin P. McCabe for comments. That's right that PBImageXmlWriter.java should use the same constants. Update the latest patch for addressing your comments and and fixing checkstyle issues.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Colin P. McCabe for comments. That's right that PBImageXmlWriter.java should use the same constants. Update the latest patch for addressing your comments and and fixing checkstyle issues.
        Hide
        cmccabe Colin P. McCabe added a comment -

        It seems reasonable to me. It seems like PBImageXmlWriter.java should use the same set of string constants. This will also ensure that the strings used during serialization are the same as the ones used during deserialization.

        Show
        cmccabe Colin P. McCabe added a comment - It seems reasonable to me. It seems like PBImageXmlWriter.java should use the same set of string constants. This will also ensure that the strings used during serialization are the same as the ones used during deserialization.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 7s trunk passed
        +1 compile 0m 52s trunk passed with JDK v1.8.0_74
        +1 compile 0m 43s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 1m 12s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 55s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 50s the patch passed with JDK v1.8.0_74
        +1 javac 0m 50s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_95
        +1 javac 0m 40s the patch passed
        -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 10 unchanged - 2 fixed = 13 total (was 12)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 12s the patch passed
        +1 javadoc 1m 13s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
        -1 unit 93m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 118m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 32s Patch does not generate ASF License warnings.
        239m 29s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
          org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793260/HDFS-9551.001.patch
        JIRA Issue HDFS-9951
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2e71756c506d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 658ee95
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14807/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14807/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 7s trunk passed +1 compile 0m 52s trunk passed with JDK v1.8.0_74 +1 compile 0m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 55s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 50s the patch passed +1 compile 0m 50s the patch passed with JDK v1.8.0_74 +1 javac 0m 50s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_95 +1 javac 0m 40s the patch passed -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 10 unchanged - 2 fixed = 13 total (was 12) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 12s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 -1 unit 93m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 118m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 32s Patch does not generate ASF License warnings. 239m 29s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2   org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793260/HDFS-9551.001.patch JIRA Issue HDFS-9951 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2e71756c506d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 658ee95 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14807/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14807/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14807/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a initial patch,what do you think of this, Colin P. McCabe.

        Show
        linyiqun Yiqun Lin added a comment - Attach a initial patch,what do you think of this, Colin P. McCabe .

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development