Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9947

Block#toString should not output information from derived classes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Block#toString should not output information from derived classes. Thanks for Chris Nauroth for spotting this bug.

      1. HDFS-9947.001.patch
        0.8 kB
        Colin P. McCabe

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the patch pending pre-commit run. Colin P. McCabe, thank you.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the patch pending pre-commit run. Colin P. McCabe , thank you.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 4s trunk passed
          +1 compile 0m 33s trunk passed with JDK v1.8.0_74
          +1 compile 0m 29s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 33s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 24s trunk passed with JDK v1.8.0_74
          +1 javadoc 0m 24s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_74
          +1 javac 0m 30s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.7.0_95
          +1 javac 0m 28s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 52s the patch passed
          +1 javadoc 0m 21s the patch passed with JDK v1.8.0_74
          +1 javadoc 0m 24s the patch passed with JDK v1.7.0_95
          +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          21m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793330/HDFS-9947.001.patch
          JIRA Issue HDFS-9947
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 792dafb41f08 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f291d82
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14810/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14810/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 4s trunk passed +1 compile 0m 33s trunk passed with JDK v1.8.0_74 +1 compile 0m 29s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 24s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 24s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_74 +1 javac 0m 30s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_95 +1 javac 0m 28s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 21s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_95 +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 21m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793330/HDFS-9947.001.patch JIRA Issue HDFS-9947 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 792dafb41f08 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f291d82 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14810/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14810/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          Regarding the pre-commit -1 for no tests, I'm willing to let it slide. This is a change in logging only, the code is unlikely to change often, and the method contract is documented well. I'm still +1.

          Show
          cnauroth Chris Nauroth added a comment - Regarding the pre-commit -1 for no tests, I'm willing to let it slide. This is a change in logging only, the code is unlikely to change often, and the method contract is documented well. I'm still +1.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Chris Nauroth. committed to 2.9

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Chris Nauroth . committed to 2.9
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9460 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9460/)
          HDFS-9947. Block#toString should not output information from derived (cmccabe: rev 9a43094e12ab8d35d49ceda2e2c5f83093bb3a5b)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/Block.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9460 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9460/ ) HDFS-9947 . Block#toString should not output information from derived (cmccabe: rev 9a43094e12ab8d35d49ceda2e2c5f83093bb3a5b) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/Block.java

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development