Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since DataNode inherits ReconfigurableBase with Configured as base class where configuration is maintained, DataNode#conf should be removed for the purpose of brevity.

      1. HDFS-9895.000.patch
        32 kB
        Xiaobing Zhou
      2. HDFS-9895.001.patch
        32 kB
        Xiaobing Zhou
      3. HDFS-9895-branch-2.003.patch
        33 kB
        Xiaobing Zhou
      4. HDFS-9895-HDFS-9000.002.patch
        34 kB
        Xiaobing Zhou
      5. HDFS-9895-HDFS-9000.003.patch
        34 kB
        Xiaobing Zhou

        Issue Links

          Activity

          Hide
          xiaobingo Xiaobing Zhou added a comment -

          The patch V000 is posted here for review, thanks!

          Show
          xiaobingo Xiaobing Zhou added a comment - The patch V000 is posted here for review, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 3s trunk passed
          +1 compile 0m 53s trunk passed with JDK v1.8.0_74
          +1 compile 0m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 57s trunk passed
          +1 javadoc 1m 15s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 56s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 50s the patch passed with JDK v1.8.0_74
          +1 javac 0m 50s the patch passed
          +1 compile 0m 42s the patch passed with JDK v1.7.0_95
          +1 javac 0m 42s the patch passed
          -1 checkstyle 0m 20s hadoop-hdfs-project/hadoop-hdfs: patch generated 9 new + 203 unchanged - 15 fixed = 212 total (was 218)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 12s the patch passed
          +1 javadoc 1m 12s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_95
          -1 unit 82m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 79m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          188m 55s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeLifeline
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.TestEditLog
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
            hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792403/HDFS-9895.000.patch
          JIRA Issue HDFS-9895
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9f61ff160daf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2e040d3
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14767/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14767/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 0m 53s trunk passed with JDK v1.8.0_74 +1 compile 0m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 15s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 56s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 49s the patch passed +1 compile 0m 50s the patch passed with JDK v1.8.0_74 +1 javac 0m 50s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_95 +1 javac 0m 42s the patch passed -1 checkstyle 0m 20s hadoop-hdfs-project/hadoop-hdfs: patch generated 9 new + 203 unchanged - 15 fixed = 212 total (was 218) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 12s the patch passed +1 javadoc 1m 12s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_95 -1 unit 82m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 79m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 188m 55s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestHFlush   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestEditLog JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.mover.TestStorageMover   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792403/HDFS-9895.000.patch JIRA Issue HDFS-9895 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9f61ff160daf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2e040d3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14767/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14767/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14767/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Current implementation does not need this because reconfiguration task (in ReconfigurableBase) does not swap Configuration instance. Are you planning to change the reconfiguration logic?

          Show
          iwasakims Masatake Iwasaki added a comment - Current implementation does not need this because reconfiguration task (in ReconfigurableBase) does not swap Configuration instance. Are you planning to change the reconfiguration logic?
          Hide
          wheat9 Haohui Mai added a comment -

          Quick question: how to ensure that different threads have a consistent view on Configuration?

          Show
          wheat9 Haohui Mai added a comment - Quick question: how to ensure that different threads have a consistent view on Configuration?
          Hide
          cmccabe Colin P. McCabe added a comment - - edited

          I think this JIRA was misleadingly titled. The patch is about removing the reference to the Configuration object inside DataNode.java, since we have a reference to the exact same configuration object in the base class. It doesn't change which aspects of the configuration we cache.

          I don't think this affects the thread-safety of anything, or the reconfiguration logic. Just like before the patch, DataNode.java is still playing with a reference to a thread-safe (but mutable) Configuration. Reconfiguration still happens by means of the ReconfigurationThread invoking the reconfigureProperty method. There is no case where as "swap a configuration instance"-- the Configured base class doesn't support swapping in a new object anyway.

          Show
          cmccabe Colin P. McCabe added a comment - - edited I think this JIRA was misleadingly titled. The patch is about removing the reference to the Configuration object inside DataNode.java , since we have a reference to the exact same configuration object in the base class. It doesn't change which aspects of the configuration we cache. I don't think this affects the thread-safety of anything, or the reconfiguration logic. Just like before the patch, DataNode.java is still playing with a reference to a thread-safe (but mutable) Configuration. Reconfiguration still happens by means of the ReconfigurationThread invoking the reconfigureProperty method. There is no case where as "swap a configuration instance"-- the Configured base class doesn't support swapping in a new object anyway.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thanks Colin P. McCabe for make it clear. It's what I meant.

          Haohui Mai when reconfiguration was proposed, consistency has been loosed. Inconsistency might be seen at some point. If strong consistency is expected, it's up to reconfiguration logic of the specific conf parameter to ensure that, e.g. DFS_DATANODE_DATA_DIR_KEY. Thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thanks Colin P. McCabe for make it clear. It's what I meant. Haohui Mai when reconfiguration was proposed, consistency has been loosed. Inconsistency might be seen at some point. If strong consistency is expected, it's up to reconfiguration logic of the specific conf parameter to ensure that, e.g. DFS_DATANODE_DATA_DIR_KEY. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user xiaobingo opened a pull request:

          https://github.com/apache/hadoop/pull/92

          HDFS-9895. Push up DataNode#conf to base class

          Please kindly review the patch v001, see also https://issues.apache.org/jira/browse/HDFS-9895.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/xiaobingo/hadoop HDFS-9895

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/92.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #92


          commit 2103ab5d37dde7ed807c9a3447a089f96071c595
          Author: Xiaobing Zhou <xzhou@hortonworks.com>
          Date: 2016-04-22T23:30:00Z

          HDFS-9895. Push up DataNode#conf to base class


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user xiaobingo opened a pull request: https://github.com/apache/hadoop/pull/92 HDFS-9895 . Push up DataNode#conf to base class Please kindly review the patch v001, see also https://issues.apache.org/jira/browse/HDFS-9895 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/xiaobingo/hadoop HDFS-9895 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit 2103ab5d37dde7ed807c9a3447a089f96071c595 Author: Xiaobing Zhou <xzhou@hortonworks.com> Date: 2016-04-22T23:30:00Z HDFS-9895 . Push up DataNode#conf to base class
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I posted patch v001 after rebase. I also created pull request for easy review, See also Github pull request

          Show
          xiaobingo Xiaobing Zhou added a comment - I posted patch v001 after rebase. I also created pull request for easy review, See also Github pull request
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 6m 56s trunk passed
          +1 compile 0m 41s trunk passed with JDK v1.8.0_77
          +1 compile 0m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 7s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.8.0_77
          +1 javac 0m 36s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_95
          +1 javac 0m 38s the patch passed
          -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 10 new + 203 unchanged - 15 fixed = 213 total (was 218)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
          -1 unit 57m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          -1 unit 54m 49s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          137m 44s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.TestDFSShell
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSShell
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.TestDecommissioningStatus



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Issue HDFS-9895
          GITHUB PR https://github.com/apache/hadoop/pull/92
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6d6c6786cf6e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 63e5412
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15259/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15259/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 56s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_77 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_77 +1 javac 0m 36s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 10 new + 203 unchanged - 15 fixed = 213 total (was 218) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 -1 unit 57m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 54m 49s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 137m 44s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestDFSShell JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.TestDecommissioningStatus Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Issue HDFS-9895 GITHUB PR https://github.com/apache/hadoop/pull/92 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d6c6786cf6e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 63e5412 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15259/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15259/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arp7 commented on a diff in the pull request:

          https://github.com/apache/hadoop/pull/92#discussion_r60831863

          — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java —
          @@ -113,71 +112,71 @@

          // Allow LAZY_PERSIST writes from non-local clients?
          private final boolean allowNonLocalLazyPersist;
          -
          + private final DataNode dn;
          private final int volFailuresTolerated;
          private final int volsConfigured;

          • public DNConf(Configuration conf) {
          • this.conf = conf;
          • socketTimeout = conf.getInt(DFS_CLIENT_SOCKET_TIMEOUT_KEY,
            + public DNConf(final DataNode dn) {
              • End diff –

          The dn.getConf() object is not referenced outside the constructor so you can just pass a reference to that object. Also DNConf need not keep a reference to the dn. I think you can just revert all changes to this file.

          Show
          githubbot ASF GitHub Bot added a comment - Github user arp7 commented on a diff in the pull request: https://github.com/apache/hadoop/pull/92#discussion_r60831863 — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java — @@ -113,71 +112,71 @@ // Allow LAZY_PERSIST writes from non-local clients? private final boolean allowNonLocalLazyPersist; - + private final DataNode dn; private final int volFailuresTolerated; private final int volsConfigured; public DNConf(Configuration conf) { this.conf = conf; socketTimeout = conf.getInt(DFS_CLIENT_SOCKET_TIMEOUT_KEY, + public DNConf(final DataNode dn) { End diff – The dn.getConf() object is not referenced outside the constructor so you can just pass a reference to that object. Also DNConf need not keep a reference to the dn. I think you can just revert all changes to this file.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arp7 commented on a diff in the pull request:

          https://github.com/apache/hadoop/pull/92#discussion_r60831889

          — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java —
          @@ -1239,9 +1236,8 @@ void startDataNode(Configuration conf,
          synchronized (this)

          { this.dataDirs = dataDirs; }
          • this.conf = conf;
          • this.dnConf = new DNConf(conf);
          • checkSecureConfig(dnConf, conf, resources);
            + this.dnConf = new DNConf(this);
              • End diff –

          If we revert changes to DNConf we can just replace this with `this.dnConf = new DNConf(getConf())`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user arp7 commented on a diff in the pull request: https://github.com/apache/hadoop/pull/92#discussion_r60831889 — Diff: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java — @@ -1239,9 +1236,8 @@ void startDataNode(Configuration conf, synchronized (this) { this.dataDirs = dataDirs; } this.conf = conf; this.dnConf = new DNConf(conf); checkSecureConfig(dnConf, conf, resources); + this.dnConf = new DNConf(this); End diff – If we revert changes to DNConf we can just replace this with `this.dnConf = new DNConf(getConf())`.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for creating the pull request Xiaobing Zhou. Couple of minor comments which will reduce the patch size but looks good otherwise.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for creating the pull request Xiaobing Zhou . Couple of minor comments which will reduce the patch size but looks good otherwise.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thank you Arpit Agarwal for review. v002 is posted. It changed dn member of DNConf as type of Configurable, since only Configurable#getConf is called.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thank you Arpit Agarwal for review. v002 is posted. It changed dn member of DNConf as type of Configurable, since only Configurable#getConf is called.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 58s trunk passed
          +1 compile 0m 58s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 50s trunk passed
          +1 javadoc 0m 57s trunk passed
          +1 mvninstall 0m 54s the patch passed
          +1 compile 0m 51s the patch passed
          +1 javac 0m 51s the patch passed
          -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 279 unchanged - 16 fixed = 289 total (was 295)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 58s the patch passed
          -1 unit 80m 28s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          102m 5s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-9895
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828553/HDFS-9895-HDFS-9000.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1f653e9c522c 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2a8f55a
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16747/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16747/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16747/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 58s trunk passed +1 compile 0m 58s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 57s trunk passed +1 mvninstall 0m 54s the patch passed +1 compile 0m 51s the patch passed +1 javac 0m 51s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 279 unchanged - 16 fixed = 289 total (was 295) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 58s the patch passed -1 unit 80m 28s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 102m 5s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9895 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828553/HDFS-9895-HDFS-9000.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1f653e9c522c 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2a8f55a Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16747/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16747/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16747/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v003 fixed check style issues.

          Show
          xiaobingo Xiaobing Zhou added a comment - v003 fixed check style issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 6m 46s trunk passed
          +1 compile 0m 46s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 43s trunk passed
          +1 javadoc 0m 55s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 277 unchanged - 18 fixed = 278 total (was 295)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 52s the patch passed
          +1 unit 59m 54s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          78m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-9895
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828722/HDFS-9895-HDFS-9000.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 75b84ddf9050 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fcbac00
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16757/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16757/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16757/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 46s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 277 unchanged - 18 fixed = 278 total (was 295) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 59m 54s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 78m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9895 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828722/HDFS-9895-HDFS-9000.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 75b84ddf9050 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fcbac00 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16757/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16757/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16757/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1. Pushed to trunk. Thanks for the contribution Xiaobing Zhou.

          If you want to post a branch-2 patch I can commit that too.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1. Pushed to trunk. Thanks for the contribution Xiaobing Zhou . If you want to post a branch-2 patch I can commit that too.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10446 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10446/)
          HDFS-9895. Remove unnecessary conf cache from DataNode. Contributed by (arp: rev ec3ea188753e2c138a64e10303c8751116dc4e80)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataXceiverLazyPersistHint.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10446 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10446/ ) HDFS-9895 . Remove unnecessary conf cache from DataNode. Contributed by (arp: rev ec3ea188753e2c138a64e10303c8751116dc4e80) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DNConf.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataXceiverLazyPersistHint.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thank you Arpit Agarwal for committing it. Branch-2 patch v003 is posted.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thank you Arpit Agarwal for committing it. Branch-2 patch v003 is posted.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HDFS-9895 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HDFS-9895
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828860/HDFS-9895-HDFS-9000-branch-2.003.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16771/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HDFS-9895 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-9895 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828860/HDFS-9895-HDFS-9000-branch-2.003.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16771/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 58s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 50s branch-2 passed
          +1 compile 0m 41s branch-2 passed with JDK v1.8.0_101
          +1 compile 0m 45s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 31s branch-2 passed
          +1 mvnsite 0m 55s branch-2 passed
          +1 mvneclipse 0m 15s branch-2 passed
          +1 findbugs 1m 59s branch-2 passed
          +1 javadoc 1m 2s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_111
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 50s the patch passed with JDK v1.8.0_101
          +1 javac 0m 50s the patch passed
          +1 compile 0m 42s the patch passed with JDK v1.7.0_111
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 276 unchanged - 17 fixed = 277 total (was 293)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 1m 0s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 45s the patch passed with JDK v1.7.0_111
          +1 unit 64m 15s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          176m 7s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-9895
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828865/HDFS-9895-branch-2.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 94c9fc92408d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 214b6d1
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16772/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16772/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16772/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 17m 58s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 50s branch-2 passed +1 compile 0m 41s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 45s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 31s branch-2 passed +1 mvnsite 0m 55s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 59s branch-2 passed +1 javadoc 1m 2s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 48s the patch passed +1 compile 0m 50s the patch passed with JDK v1.8.0_101 +1 javac 0m 50s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_111 +1 javac 0m 42s the patch passed -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 276 unchanged - 17 fixed = 277 total (was 293) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 1m 0s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_111 +1 unit 64m 15s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 176m 7s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9895 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828865/HDFS-9895-branch-2.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 94c9fc92408d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 214b6d1 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16772/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16772/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16772/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks Xiaobing Zhou. Pushed to branch-2.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks Xiaobing Zhou . Pushed to branch-2.

            People

            • Assignee:
              xiaobingo Xiaobing Zhou
              Reporter:
              xiaobingo Xiaobing Zhou
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development