Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9851

Name node throws NPE when setPermission is called on a path that does not exist

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7.1, 2.7.2
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Tried it on both Hadoop 2.7.1 and 2.7.2, and I'm getting the same error when setPermission is called on a path that does not exist:

      16/02/23 16:37:03.888 DEBUG security.UserGroupInformation:FSPermissionChecker.ja
      va:164 - ACCESS CHECK: org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker@299b19af, doCheckOwner=true, ancestorAccess=null, parentAccess=null, access=null, subAccess=null, ignoreEmptyDir=false
      16/02/23 16:37:03.889 DEBUG ipc.Server:ProtobufRpcEngine.java:631 - Served: setPermission queueTime= 3 procesingTime= 3 exception= NullPointerException
      16/02/23 16:37:03.890 WARN ipc.Server:Server.java:2068 - IPC Server handler 2 on 9000, call org.apache.hadoop.hdfs.protocol.ClientProtocol.setPermission from 127.0.0.1:36190 Call#21 Retry#0
      java.lang.NullPointerException
              at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkOwner(FSPermissionChecker.java:247)
              at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:227)
              at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:190)
              at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1720)
              at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1704)
              at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkOwner(FSDirectory.java:1673)
              at org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.setPermission(FSDirAttrOp.java:61)
              at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setPermission(FSNamesystem.java:1653)
              at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setPermission(NameNodeRpcServer.java:695)
              at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setPermission(ClientNamenodeProtocolServerSideTranslatorPB.java:453)
              at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
              at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:616)
              at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:969)
              at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2049)
              at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2045)
              at java.security.AccessController.doPrivileged(Native Method)
              at javax.security.auth.Subject.doAs(Subject.java:415)
              at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
              at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2043)
      

      I don't see this problem with Hadoop 2.6.x.
      The client that issues the setPermission call was compiled with Hadoop 2.2.0 libraries.

      1. HDFS-9851.patch
        4 kB
        Brahma Reddy Battula
      2. HDFS-9851-002.patch
        5 kB
        Brahma Reddy Battula
      3. HDFS-9851-branch-2.7.patch
        4 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9410 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9410/)
          HDFS-9851. NameNode throws NPE when setPermission is called on a path (aajisaka: rev 27e0681f28ee896ada163bbbc08fd44d113e7d15)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9410 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9410/ ) HDFS-9851 . NameNode throws NPE when setPermission is called on a path (aajisaka: rev 27e0681f28ee896ada163bbbc08fd44d113e7d15) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks for review and commit.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks for review and commit.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2.7 and above. Thanks Brahma Reddy Battula for the contribution and thanks Mingliang Liu for the review!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7 and above. Thanks Brahma Reddy Battula for the contribution and thanks Mingliang Liu for the review!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          testfailures are unrelated...Akira Ajisaka can you please take a look...?

          Show
          brahmareddy Brahma Reddy Battula added a comment - testfailures are unrelated... Akira Ajisaka can you please take a look...?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 15s branch-2.7 passed
          +1 compile 0m 57s branch-2.7 passed with JDK v1.8.0_72
          +1 compile 0m 59s branch-2.7 passed with JDK v1.7.0_95
          +1 checkstyle 0m 27s branch-2.7 passed
          +1 mvnsite 1m 0s branch-2.7 passed
          +1 mvneclipse 0m 15s branch-2.7 passed
          -1 findbugs 3m 6s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings.
          +1 javadoc 1m 12s branch-2.7 passed with JDK v1.8.0_72
          +1 javadoc 1m 53s branch-2.7 passed with JDK v1.7.0_95
          +1 mvninstall 0m 53s the patch passed
          +1 compile 0m 56s the patch passed with JDK v1.8.0_72
          +1 javac 0m 56s the patch passed
          +1 compile 0m 59s the patch passed with JDK v1.7.0_95
          +1 javac 0m 59s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          -1 whitespace 0m 0s The patch has 1879 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 47s The patch has 117 line(s) with tabs.
          +1 findbugs 3m 9s the patch passed
          +1 javadoc 1m 7s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 51s the patch passed with JDK v1.7.0_95
          -1 unit 43m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 43m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          -1 asflicense 42m 59s Patch generated 81 ASF License warnings.
          162m 36s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.tools.TestJMXGet
            hadoop.hdfs.server.blockmanagement.TestPendingReplication
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          JDK v1.7.0_95 Failed junit tests hadoop.tools.TestJMXGet
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790438/HDFS-9851-branch-2.7.patch
          JIRA Issue HDFS-9851
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0c306751290f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / e14ab93
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14654/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14654/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 15s branch-2.7 passed +1 compile 0m 57s branch-2.7 passed with JDK v1.8.0_72 +1 compile 0m 59s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 0m 27s branch-2.7 passed +1 mvnsite 1m 0s branch-2.7 passed +1 mvneclipse 0m 15s branch-2.7 passed -1 findbugs 3m 6s hadoop-hdfs-project/hadoop-hdfs in branch-2.7 has 1 extant Findbugs warnings. +1 javadoc 1m 12s branch-2.7 passed with JDK v1.8.0_72 +1 javadoc 1m 53s branch-2.7 passed with JDK v1.7.0_95 +1 mvninstall 0m 53s the patch passed +1 compile 0m 56s the patch passed with JDK v1.8.0_72 +1 javac 0m 56s the patch passed +1 compile 0m 59s the patch passed with JDK v1.7.0_95 +1 javac 0m 59s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1879 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 47s The patch has 117 line(s) with tabs. +1 findbugs 3m 9s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 51s the patch passed with JDK v1.7.0_95 -1 unit 43m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 43m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 42m 59s Patch generated 81 ASF License warnings. 162m 36s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.tools.TestJMXGet   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.7.0_95 Failed junit tests hadoop.tools.TestJMXGet   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790438/HDFS-9851-branch-2.7.patch JIRA Issue HDFS-9851 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0c306751290f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / e14ab93 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14654/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14654/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14654/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Akira Ajisaka thanks for review, Uploaded the patch for branch-2.7..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for review, Uploaded the patch for branch-2.7..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Guarding in checkOwner seems ok to me.

          Agree.

          The patch looks good to me, but it cannot be applied to branch-2.7 cleanly. Would you provide a patch for branch-2.7?

          Show
          ajisakaa Akira Ajisaka added a comment - Guarding in checkOwner seems ok to me. Agree. The patch looks good to me, but it cannot be applied to branch-2.7 cleanly. Would you provide a patch for branch-2.7?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Test case failures are unrelated.. can somebody review this..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Test case failures are unrelated.. can somebody review this..?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 24s trunk passed
          +1 compile 0m 37s trunk passed with JDK v1.8.0_72
          +1 compile 0m 39s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 49s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 52s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_72
          +1 javac 0m 35s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_95
          +1 javac 0m 38s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95
          +1 unit 52m 10s hadoop-hdfs in the patch passed with JDK v1.8.0_72.
          -1 unit 49m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          126m 3s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790101/HDFS-9851-002.patch
          JIRA Issue HDFS-9851
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4dd5359b2950 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d7fdec1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14627/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14627/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14627/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14627/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 24s trunk passed +1 compile 0m 37s trunk passed with JDK v1.8.0_72 +1 compile 0m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_72 +1 javac 0m 35s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95 +1 unit 52m 10s hadoop-hdfs in the patch passed with JDK v1.8.0_72. -1 unit 49m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 126m 3s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790101/HDFS-9851-002.patch JIRA Issue HDFS-9851 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4dd5359b2950 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d7fdec1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14627/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14627/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14627/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14627/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Mingliang Liu thanks for review.Uploaded the patch to fix the testcase failure and above comment..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Mingliang Liu thanks for review.Uploaded the patch to fix the testcase failure and above comment..
          Hide
          liuml07 Mingliang Liu added a comment -

          Guarding in checkOwner seems ok to me.

          282	      try {
          283	        userfs.setPermission(CHILD_FILE3, new FsPermission((short) 0777));
          284	        assertTrue(false);
          285	      } catch (java.io.FileNotFoundException e) {
          286	        LOG.info("GOOD: got " + e);
          287	      }
          

          May be cleaner as following:

          	      try {
          	        userfs.setPermission(CHILD_FILE3, new FsPermission((short) 0777));
          	        fail("some error message as the file is not found...");
          	      } catch (java.io.FileNotFoundException ignored) {
          	      }
          
          Show
          liuml07 Mingliang Liu added a comment - Guarding in checkOwner seems ok to me. 282 try { 283 userfs.setPermission(CHILD_FILE3, new FsPermission(( short ) 0777)); 284 assertTrue( false ); 285 } catch (java.io.FileNotFoundException e) { 286 LOG.info( "GOOD: got " + e); 287 } May be cleaner as following: try { userfs.setPermission(CHILD_FILE3, new FsPermission(( short ) 0777)); fail( "some error message as the file is not found..." ); } catch (java.io.FileNotFoundException ignored) { }
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 11m 35s trunk passed
          +1 compile 1m 43s trunk passed with JDK v1.8.0_72
          +1 compile 1m 15s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 37s trunk passed
          +1 mvnsite 1m 32s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 19s trunk passed
          +1 javadoc 1m 23s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 58s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 56s the patch passed with JDK v1.8.0_72
          +1 javac 0m 56s the patch passed
          +1 compile 0m 45s the patch passed with JDK v1.7.0_95
          +1 javac 0m 45s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 10s the patch passed
          +1 javadoc 1m 21s the patch passed with JDK v1.8.0_72
          +1 javadoc 2m 8s the patch passed with JDK v1.7.0_95
          -1 unit 90m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 90m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          217m 8s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789546/HDFS-9851.patch
          JIRA Issue HDFS-9851
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9f6478c46af2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3369a4f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14595/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14595/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 35s trunk passed +1 compile 1m 43s trunk passed with JDK v1.8.0_72 +1 compile 1m 15s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 32s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 19s trunk passed +1 javadoc 1m 23s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 58s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 50s the patch passed +1 compile 0m 56s the patch passed with JDK v1.8.0_72 +1 javac 0m 56s the patch passed +1 compile 0m 45s the patch passed with JDK v1.7.0_95 +1 javac 0m 45s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 21s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 8s the patch passed with JDK v1.7.0_95 -1 unit 90m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 90m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 217m 8s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.TestDFSShell   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789546/HDFS-9851.patch JIRA Issue HDFS-9851 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9f6478c46af2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3369a4f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14595/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14595/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14595/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          David Yan thanks for reporting this issue...

          this will come when non-super user try to setpermission.. Upload patch with testcase... kindly review...

          Show
          brahmareddy Brahma Reddy Battula added a comment - David Yan thanks for reporting this issue... this will come when non-super user try to setpermission.. Upload patch with testcase... kindly review...
          Hide
          liuml07 Mingliang Liu added a comment -

          The expected exception should be java.io.FileNotFoundException with error message like "File does not exist: /nonExistingDir".

          It seems that the FSPermissionChecker#checkOwner should simply return in case of null INodeAttributes argument. I'm wondering how the null value is passed through it and no one checks this.

          Show
          liuml07 Mingliang Liu added a comment - The expected exception should be java.io.FileNotFoundException with error message like "File does not exist: /nonExistingDir". It seems that the FSPermissionChecker#checkOwner should simply return in case of null INodeAttributes argument. I'm wondering how the null value is passed through it and no one checks this.

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              davidyan David Yan
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development