Details
-
Bug
-
Status: Resolved
-
Blocker
-
Resolution: Fixed
-
2.8.0
-
None
-
Reviewed
Description
if ((ez != null)) { return this.makeQualified( new Path(ez.getPath() + "/" + FileSystem.TRASH_PREFIX + dfs.ugi.getShortUserName()));
This doesn't handle root dir correctly. The unit test testRootDirEZTrash in the attached patch can reproduce the error.
Attachments
Attachments
- HDFS-9844.00.patch
- 2 kB
- Zhe Zhang
Issue Links
- relates to
-
HDFS-8831 Trash Support for deletion in HDFS encryption zone
- Resolved
Activity
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 14s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
0 | mvndep | 0m 11s | Maven dependency ordering for branch |
+1 | mvninstall | 7m 31s | trunk passed |
+1 | compile | 1m 51s | trunk passed with JDK v1.8.0_72 |
+1 | compile | 1m 32s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 27s | trunk passed |
+1 | mvnsite | 1m 36s | trunk passed |
+1 | mvneclipse | 0m 26s | trunk passed |
+1 | findbugs | 3m 37s | trunk passed |
+1 | javadoc | 1m 46s | trunk passed with JDK v1.8.0_72 |
+1 | javadoc | 2m 28s | trunk passed with JDK v1.7.0_95 |
0 | mvndep | 0m 9s | Maven dependency ordering for patch |
+1 | mvninstall | 1m 25s | the patch passed |
+1 | compile | 1m 52s | the patch passed with JDK v1.8.0_72 |
+1 | javac | 1m 52s | the patch passed |
+1 | compile | 1m 35s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 1m 35s | the patch passed |
+1 | checkstyle | 0m 24s | the patch passed |
+1 | mvnsite | 1m 32s | the patch passed |
+1 | mvneclipse | 0m 23s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 4m 13s | the patch passed |
+1 | javadoc | 1m 44s | the patch passed with JDK v1.8.0_72 |
+1 | javadoc | 2m 26s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 1m 7s | hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. |
-1 | unit | 111m 10s | hadoop-hdfs in the patch failed with JDK v1.8.0_72. |
+1 | unit | 1m 33s | hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. |
-1 | unit | 119m 13s | hadoop-hdfs in the patch failed with JDK v1.7.0_95. |
+1 | asflicense | 0m 52s | Patch does not generate ASF License warnings. |
274m 15s |
Reason | Tests |
---|---|
JDK v1.8.0_72 Failed junit tests | hadoop.hdfs.TestDFSUpgradeFromImage |
hadoop.tracing.TestTracing | |
hadoop.hdfs.server.namenode.ha.TestEditLogTailer | |
hadoop.hdfs.security.TestDelegationTokenForProxyUser | |
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure | |
hadoop.hdfs.server.datanode.TestBlockReplacement | |
hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits | |
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes | |
hadoop.hdfs.server.namenode.TestDecommissioningStatus | |
hadoop.hdfs.server.namenode.TestFileTruncate | |
hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider | |
hadoop.hdfs.server.datanode.TestDirectoryScanner | |
JDK v1.8.0_72 Timed out junit tests | org.apache.hadoop.hdfs.TestLeaseRecovery2 |
JDK v1.7.0_95 Failed junit tests | hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency |
hadoop.hdfs.server.namenode.ha.TestEditLogTailer | |
hadoop.hdfs.TestPersistBlocks | |
hadoop.hdfs.server.blockmanagement.TestBlockManager | |
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl | |
hadoop.hdfs.security.TestDelegationTokenForProxyUser | |
hadoop.hdfs.TestLocalDFS | |
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure | |
hadoop.hdfs.server.datanode.TestBlockReplacement | |
hadoop.hdfs.server.namenode.TestDecommissioningStatus | |
hadoop.hdfs.qjournal.TestSecureNNWithQJM | |
hadoop.hdfs.server.namenode.TestFileTruncate | |
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery | |
hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot | |
hadoop.hdfs.server.datanode.TestDirectoryScanner |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 12s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
0 | mvndep | 0m 31s | Maven dependency ordering for branch |
+1 | mvninstall | 7m 5s | trunk passed |
+1 | compile | 1m 35s | trunk passed with JDK v1.8.0_72 |
+1 | compile | 1m 22s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 25s | trunk passed |
+1 | mvnsite | 1m 26s | trunk passed |
+1 | mvneclipse | 0m 24s | trunk passed |
+1 | findbugs | 3m 33s | trunk passed |
+1 | javadoc | 1m 32s | trunk passed with JDK v1.8.0_72 |
+1 | javadoc | 2m 11s | trunk passed with JDK v1.7.0_95 |
0 | mvndep | 0m 8s | Maven dependency ordering for patch |
+1 | mvninstall | 1m 18s | the patch passed |
+1 | compile | 1m 35s | the patch passed with JDK v1.8.0_72 |
+1 | javac | 1m 35s | the patch passed |
+1 | compile | 1m 26s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 1m 26s | the patch passed |
+1 | checkstyle | 0m 24s | the patch passed |
+1 | mvnsite | 1m 26s | the patch passed |
+1 | mvneclipse | 0m 20s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 3m 56s | the patch passed |
+1 | javadoc | 1m 31s | the patch passed with JDK v1.8.0_72 |
+1 | javadoc | 2m 13s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 0m 54s | hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. |
-1 | unit | 65m 53s | hadoop-hdfs in the patch failed with JDK v1.8.0_72. |
+1 | unit | 0m 58s | hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. |
-1 | unit | 56m 28s | hadoop-hdfs in the patch failed with JDK v1.7.0_95. |
+1 | asflicense | 0m 33s | Patch does not generate ASF License warnings. |
161m 46s |
Reason | Tests |
---|---|
JDK v1.8.0_72 Failed junit tests | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
hadoop.hdfs.TestEncryptionZones | |
hadoop.hdfs.TestFileAppend | |
JDK v1.7.0_95 Failed junit tests | hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs |
This message was automatically generated.
Thanks Andrew! All reported test failures are unrelated and pass locally. The TestEncryptionZones failure is a timeout and is unrelated to the change. I just committed the patch to trunk, branch-2, and branch-2.8.
FAILURE: Integrated in Hadoop-trunk-Commit #9356 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9356/)
HDFS-9844. Correct path creation in getTrashRoot to handle root dir. (zhz: rev 647a35e996d33d8df898891760305222446b68f5)
- hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
LGTM +1 pending Jenkins, thanks Zhe