[HDFS-9829] Erasure Coding: Improve few exception handling logic of ErasureCodingWorker

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha1
• Component/s: erasure-coding
• Hadoop Flags: Reviewed
• Assignee: Rakesh Radhakrishnan
• Reporter: Rakesh Radhakrishnan
• Created: 18/Feb/16 17:33
• Updated: 12/May/16 18:14
• Resolved: 19/Feb/16 18:42

Description

1. Cancel remaining reads on InterruptedException.

   	} catch (InterruptedException e) {
             LOG.info("Read data interrupted.", e);
             break;
           }
   

2. Shouldn't fail recontruction due to an IOException errors while reporting corrupt blocks.

             } finally {
               // report corrupted blocks to NN
               reportCorruptedBlocks(corruptionMap);
             }
   

3. ECW#closeBlockReader() function can be simplified using IOUtils.closeStream(closable)
4. Also, use {} instead of string concatenation in logger.

   LOG.debug("Using striped reads; pool threads=" + num);
   //...
   LOG.warn("Found Checksum error for " + reader.block + " from "
                   + reader.source + " at " + e.getPos());
   //...
   LOG.debug("Using striped block reconstruction; pool threads=" + num);
   //..
   LOG.warn("Failed to reconstruct striped block: " + blockGroup, e);