Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9795

OIV Delimited should show which files are ACL-enabled.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:

      Description

      In hdfs oiv delimited output, there is no easy way to see whether a file has ACLs.

      FsShell shows a + in the permission.

      1. HDFS-9795.01.patch
        4 kB
        Lei (Eddy) Xu
      2. HDFS-9795.02.patch
        4 kB
        Lei (Eddy) Xu

        Activity

        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Upload the patch to indicate the file has ACL entries in OIV delimited outputs.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Upload the patch to indicate the file has ACL entries in OIV delimited outputs.
        Hide
        andrew.wang Andrew Wang added a comment -

        LGTM except for one nit, I think we should print "" rather than " " if there aren't any ACLs. Otherwise +1 pending this and Jenkins, thanks Lei (Eddy) Xu.

        Show
        andrew.wang Andrew Wang added a comment - LGTM except for one nit, I think we should print "" rather than " " if there aren't any ACLs. Otherwise +1 pending this and Jenkins, thanks Lei (Eddy) Xu .
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks, Andrew Wang. I updated the patch to address your comment..

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks, Andrew Wang . I updated the patch to address your comment..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 27s trunk passed
        +1 compile 0m 37s trunk passed with JDK v1.8.0_72
        +1 compile 0m 40s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 52s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_72
        +1 javac 0m 35s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.7.0_95
        +1 javac 0m 38s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 4s the patch passed
        +1 javadoc 1m 5s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95
        -1 unit 52m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 unit 54m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        130m 9s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.fs.TestHdfsNativeCodeLoader
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.fs.TestHdfsNativeCodeLoader



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787579/HDFS-9795.02.patch
        JIRA Issue HDFS-9795
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dffc1157e1a1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 23f937e
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14467/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14467/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 27s trunk passed +1 compile 0m 37s trunk passed with JDK v1.8.0_72 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_72 +1 javac 0m 35s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95 -1 unit 52m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 54m 1s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 130m 9s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.fs.TestHdfsNativeCodeLoader JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.fs.TestHdfsNativeCodeLoader Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787579/HDFS-9795.02.patch JIRA Issue HDFS-9795 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dffc1157e1a1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23f937e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14467/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14467/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        The test failures are not relevant. +1 and committed to trunk.

        Due to the format changes in OIV delimited outputs, so I do not committed it into branch-2 and branch-2.8.

        Thanks Andrew Wang for the reviews.

        Show
        eddyxu Lei (Eddy) Xu added a comment - The test failures are not relevant. +1 and committed to trunk. Due to the format changes in OIV delimited outputs, so I do not committed it into branch-2 and branch-2.8. Thanks Andrew Wang for the reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9288 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9288/)
        HDFS-9795. OIV Delimited should show which files are ACL-enabled (lei) (lei: rev c7fcec24b845fc7c74cc50f16931305bb526dba6)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageDelimitedTextWriter.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9288 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9288/ ) HDFS-9795 . OIV Delimited should show which files are ACL-enabled (lei) (lei: rev c7fcec24b845fc7c74cc50f16931305bb526dba6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageDelimitedTextWriter.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            eddyxu Lei (Eddy) Xu
            Reporter:
            eddyxu Lei (Eddy) Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development