Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9784

Example usage is not correct in Transparent Encryption document

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It says

      # As the normal user, create a new encryption key
      hadoop key create myKey
      

      But, this actually fails with the below error.

      $ hadoop key create myKey
      java.lang.IllegalArgumentException: Uppercase key names are unsupported: myKey
          at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
          at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
          at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
          at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
          at org.apache.hadoop.util.HttpExceptionUtils.validateResponse(HttpExceptionUtils.java:157)
          at org.apache.hadoop.crypto.key.kms.KMSClientProvider.call(KMSClientProvider.java:546)
          at org.apache.hadoop.crypto.key.kms.KMSClientProvider.call(KMSClientProvider.java:504)
          at org.apache.hadoop.crypto.key.kms.KMSClientProvider.createKeyInternal(KMSClientProvider.java:677)
          at org.apache.hadoop.crypto.key.kms.KMSClientProvider.createKey(KMSClientProvider.java:685)
          at org.apache.hadoop.crypto.key.KeyShell$CreateCommand.execute(KeyShell.java:483)
          at org.apache.hadoop.crypto.key.KeyShell.run(KeyShell.java:79)
          at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
          at org.apache.hadoop.crypto.key.KeyShell.main(KeyShell.java:515)
      

      Though I'm not sure why it is so, I think the document should be fixed to use only lowercase in key names.

      1. HADOOP-12779.1.patch
        0.9 kB
        Takashi Ohnishi

        Issue Links

          Activity

          Hide
          bwtakacy Takashi Ohnishi added a comment -

          Attached patch

          Show
          bwtakacy Takashi Ohnishi added a comment - Attached patch
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvnsite 1m 4s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvnsite 0m 57s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          3m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786704/HADOOP-12779.1.patch
          JIRA Issue HADOOP-12779
          Optional Tests asflicense mvnsite
          uname Linux 66c7664510b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5b59a0e
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 30MB
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8564/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvnsite 1m 4s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvnsite 0m 57s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 3m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786704/HADOOP-12779.1.patch JIRA Issue HADOOP-12779 Optional Tests asflicense mvnsite uname Linux 66c7664510b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5b59a0e modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 30MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8564/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, the fix looks good to me.
          I found the usage of "hadoop key" is not documented anywhere, so we should document the usage in a separate jira. In addition, we need to document that uppercase is not allowed for key name.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, the fix looks good to me. I found the usage of "hadoop key" is not documented anywhere, so we should document the usage in a separate jira. In addition, we need to document that uppercase is not allowed for key name.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Takashi Ohnishi for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Takashi Ohnishi for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment - - edited

          Filed HADOOP-12786 for documenting "hadoop key" command usage.

          Show
          ajisakaa Akira Ajisaka added a comment - - edited Filed HADOOP-12786 for documenting "hadoop key" command usage.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9268 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9268/)
          HDFS-9784. Example usage is not correct in Transparent Encryption (aajisaka: rev 60d2011b7c0fe55b8bc44a141660d3e2df37a68d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9268 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9268/ ) HDFS-9784 . Example usage is not correct in Transparent Encryption (aajisaka: rev 60d2011b7c0fe55b8bc44a141660d3e2df37a68d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/TransparentEncryption.md
          Hide
          bwtakacy Takashi Ohnishi added a comment -

          Thanks Akira Ajisaka for committing

          Show
          bwtakacy Takashi Ohnishi added a comment - Thanks Akira Ajisaka for committing
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              bwtakacy Takashi Ohnishi
              Reporter:
              bwtakacy Takashi Ohnishi
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development