Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9779

TestReplicationPolicyWithNodeGroup NODE variable picks wrong rack value

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The DatanodeDescriptor object for NODE calls the wrong constructor on an already created DatanodeDescriptor object. This overwrites the networkLocation value to "default-rack" instead of expected value of "/d2/r4/n7". I didn't find any other such malformed calls to DFSTestUtil.getDatanodeDescriptor

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        kihwal Kihwal Lee added a comment -

        Cherry-picked to branch-2.7.

        Show
        kihwal Kihwal Lee added a comment - Cherry-picked to branch-2.7.
        Hide
        shahrs87 Rushabh S Shah added a comment -

        Uma Maheswara Rao G: does it make sense to put the change in branch-2.7 also ?

        Show
        shahrs87 Rushabh S Shah added a comment - Uma Maheswara Rao G : does it make sense to put the change in branch-2.7 also ?
        Hide
        kshukla Kuhu Shukla added a comment -

        Thank you Uma!

        Show
        kshukla Kuhu Shukla added a comment - Thank you Uma!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9271 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9271/)
        HDFS-9779 . TestReplicationPolicyWithNodeGroup NODE variable picks wrong (uma.gangumalla: rev a7fce9ab415fcc834ca1d91f913157ffd103fa5f)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyWithNodeGroup.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9271 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9271/ ) HDFS-9779 . TestReplicationPolicyWithNodeGroup NODE variable picks wrong (uma.gangumalla: rev a7fce9ab415fcc834ca1d91f913157ffd103fa5f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Thanks for the contribution Kuhu Shukla. Thanks for the reviews Rushabh S Shah

        +1, I have just pushed it to trunk, branch-2 and 2.8

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Thanks for the contribution Kuhu Shukla . Thanks for the reviews Rushabh S Shah +1, I have just pushed it to trunk, branch-2 and 2.8
        Hide
        shahrs87 Rushabh S Shah added a comment -

        +1 lgtm (non-binding)

        Show
        shahrs87 Rushabh S Shah added a comment - +1 lgtm (non-binding)
        Hide
        kshukla Kuhu Shukla added a comment -

        Test failures are unrelated. Request for comments, Kihwal Lee, Rushabh S Shah.

        Show
        kshukla Kuhu Shukla added a comment - Test failures are unrelated. Request for comments, Kihwal Lee , Rushabh S Shah .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 39s trunk passed
        +1 compile 0m 42s trunk passed with JDK v1.8.0_72
        +1 compile 0m 39s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 54s trunk passed
        +1 javadoc 1m 12s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_72
        +1 javac 0m 35s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.7.0_95
        +1 javac 0m 37s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95
        -1 unit 62m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 unit 59m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        148m 33s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.TestDatanodeRegistration
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.TestDFSUpgradeFromImage
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786861/HDFS-9779.001.patch
        JIRA Issue HDFS-9779
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e53b6f2785b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 193d27d
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14428/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14428/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 39s trunk passed +1 compile 0m 42s trunk passed with JDK v1.8.0_72 +1 compile 0m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_72 +1 javac 0m 35s the patch passed +1 compile 0m 37s the patch passed with JDK v1.7.0_95 +1 javac 0m 37s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95 -1 unit 62m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 59m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 148m 33s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786861/HDFS-9779.001.patch JIRA Issue HDFS-9779 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e53b6f2785b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 193d27d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14428/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14428/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kshukla Kuhu Shukla added a comment -

        Attaching patch. No test included since the only change is the test file.

        Show
        kshukla Kuhu Shukla added a comment - Attaching patch. No test included since the only change is the test file.

          People

          • Assignee:
            kshukla Kuhu Shukla
            Reporter:
            kshukla Kuhu Shukla
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development