Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-977

DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      My IDE tells me that this code snippet in DataNode.createInterDataNodeProtocolProxy() is guarding the info log entry at debug level, and it should be reviewed

          if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
            InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
          }
      
      1. HDFS-977.r2.diff
        0.8 kB
        Harsh J
      2. HDFS-977.r1.diff
        0.8 kB
        Harsh J

        Activity

        steve_l created issue -
        Gavin made changes -
        Field Original Value New Value
        Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
        Harsh J made changes -
        Attachment HDFS-977.r1.diff [ 12478501 ]
        Harsh J made changes -
        Assignee Harsh J Chouraria [ qwertymaniac ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note DataNode.createInterDataNodeProtocolProxy() guarded a log at the wrong level
        Fix Version/s 0.23.0 [ 12315571 ]
        Harsh J made changes -
        Attachment HDFS-977.r2.diff [ 12480430 ]
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Release Note DataNode.createInterDataNodeProtocolProxy() guarded a log at the wrong level
        Resolution Fixed [ 1 ]
        Todd Lipcon made changes -
        Fix Version/s 0.22.0 [ 12314241 ]
        Fix Version/s 0.23.0 [ 12315571 ]

          People

          • Assignee:
            Harsh J
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development