Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-977

DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      My IDE tells me that this code snippet in DataNode.createInterDataNodeProtocolProxy() is guarding the info log entry at debug level, and it should be reviewed

          if (InterDatanodeProtocol.LOG.isDebugEnabled()) {
            InterDatanodeProtocol.LOG.info("InterDatanodeProtocol addr=" + addr);
          }
      
      1. HDFS-977.r2.diff
        0.8 kB
        Harsh J
      2. HDFS-977.r1.diff
        0.8 kB
        Harsh J

        Activity

        steve_l created issue -
        Gavin made changes -
        Field Original Value New Value
        Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
        Hide
        Harsh J added a comment -

        This is better as a DEBUG log since it may get called repeatedly for recovery blocks?

        Show
        Harsh J added a comment - This is better as a DEBUG log since it may get called repeatedly for recovery blocks?
        Harsh J made changes -
        Attachment HDFS-977.r1.diff [ 12478501 ]
        Harsh J made changes -
        Assignee Harsh J Chouraria [ qwertymaniac ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note DataNode.createInterDataNodeProtocolProxy() guarded a log at the wrong level
        Fix Version/s 0.23.0 [ 12315571 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478501/HDFS-977.r1.diff
        against trunk revision 1127390.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/622//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478501/HDFS-977.r1.diff against trunk revision 1127390. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/622//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Can you re-upload as a -p0 patch?

        Show
        Todd Lipcon added a comment - Can you re-upload as a -p0 patch?
        Hide
        Harsh J added a comment -

        Sorry about that!

        Show
        Harsh J added a comment - Sorry about that!
        Harsh J made changes -
        Attachment HDFS-977.r2.diff [ 12480430 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480430/HDFS-977.r2.diff
        against trunk revision 1127390.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480430/HDFS-977.r2.diff against trunk revision 1127390. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/624//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Log level change - No TCase required.

        Show
        Harsh J added a comment - Log level change - No TCase required.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk and 0.22. Thanks Harsh!

        P.S. No need to fill in "release note" for small changes like this that users don't need to know about when upgrading. It's mostly meant for new features or changes an operator/user should really be aware of.

        Show
        Todd Lipcon added a comment - Committed to trunk and 0.22. Thanks Harsh! P.S. No need to fill in "release note" for small changes like this that users don't need to know about when upgrading. It's mostly meant for new features or changes an operator/user should really be aware of.
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Release Note DataNode.createInterDataNodeProtocolProxy() guarded a log at the wrong level
        Resolution Fixed [ 1 ]
        Todd Lipcon made changes -
        Fix Version/s 0.22.0 [ 12314241 ]
        Fix Version/s 0.23.0 [ 12315571 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #696 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/696/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #696 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/696/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #682 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/682/)
        HDFS-977. DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level. Contributed by Harsh J Chouraria.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128986
        Files :

        • /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #682 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/682/ ) HDFS-977 . DataNode.createInterDataNodeProtocolProxy() guards a log at the wrong level. Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128986 Files : /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/hdfs/trunk/CHANGES.txt
        Hide
        Suresh Srinivas added a comment -

        Todd, I see few commits to 0.22 that are not blockers. We should be committing only blockers to 0.22 at this time right? Any other content requires a vote.

        BTW HDFS-1954 that was committed might have resulted in failed TestMissingBlocksAlert failing.

        Show
        Suresh Srinivas added a comment - Todd, I see few commits to 0.22 that are not blockers. We should be committing only blockers to 0.22 at this time right? Any other content requires a vote. BTW HDFS-1954 that was committed might have resulted in failed TestMissingBlocksAlert failing.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #61 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/61/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #61 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/61/ )

          People

          • Assignee:
            Harsh J
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development