Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9752

Permanent write failures may happen to slow writers during datanode rolling upgrades

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When datanodes are being upgraded, an out-of-band ack is sent upstream and the client does a pipeline recovery. The client may hit this multiple times as more nodes get upgraded. This normally does not cause any issue, but if the client is holding the stream open without writing any data during this time, a permanent write failure can occur.

      This is because there is a limit of 5 recovery trials for the same packet, which is tracked by "last acked sequence number". Since the empty heartbeat packets for an idle output stream does not increment the sequence number, the write will fail after it seeing 5 pipeline breakages by datanode upgrades.

      This check/limit was added to avoid spinning until running out of nodes in the cluster due to a corruption or any other irrecoverable conditions. The datanode upgrade-restart should be excluded from the count.

      1. HdfsWriter.java
        2 kB
        Xiaobing Zhou
      2. HDFS-9752-branch-2.7.03.patch
        11 kB
        Walter Su
      3. HDFS-9752-branch-2.6.03.patch
        11 kB
        Walter Su
      4. HDFS-9752.03.patch
        12 kB
        Walter Su
      5. HDFS-9752.02.patch
        7 kB
        Walter Su
      6. HDFS-9752.01.patch
        7 kB
        Walter Su

        Activity

        Hide
        walter.k.su Walter Su added a comment -

        Thanks Kihwal Lee for reporting this.
        Uploaded 01 patch, kindly review. The patch resets pipelineRecoveryCount every time a packet is successfully sent.

        Show
        walter.k.su Walter Su added a comment - Thanks Kihwal Lee for reporting this. Uploaded 01 patch, kindly review. The patch resets pipelineRecoveryCount every time a packet is successfully sent.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 27s Maven dependency ordering for branch
        +1 mvninstall 7m 37s trunk passed
        +1 compile 1m 49s trunk passed with JDK v1.8.0_66
        +1 compile 1m 31s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 2m 8s trunk passed
        +1 mvneclipse 0m 41s trunk passed
        +1 findbugs 4m 31s trunk passed
        +1 javadoc 1m 54s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 6s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 25s Maven dependency ordering for patch
        +1 mvninstall 1m 54s the patch passed
        +1 compile 2m 35s the patch passed with JDK v1.8.0_66
        +1 javac 2m 35s the patch passed
        +1 compile 2m 2s the patch passed with JDK v1.7.0_91
        +1 javac 2m 2s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 1m 28s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 1s Patch has no whitespace issues.
        +1 findbugs 4m 9s the patch passed
        +1 javadoc 1m 45s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 28s the patch passed with JDK v1.7.0_91
        +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 91m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 79m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        218m 18s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.tracing.TestTracing
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
          hadoop.hdfs.TestSafeMode
          hadoop.hdfs.server.datanode.TestBlockReplacement



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786210/HDFS-9752.01.patch
        JIRA Issue HDFS-9752
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f0d6180ae6d9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 63c63e2
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14379/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14379/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 7m 37s trunk passed +1 compile 1m 49s trunk passed with JDK v1.8.0_66 +1 compile 1m 31s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 2m 8s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 4m 31s trunk passed +1 javadoc 1m 54s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 6s trunk passed with JDK v1.7.0_91 0 mvndep 0m 25s Maven dependency ordering for patch +1 mvninstall 1m 54s the patch passed +1 compile 2m 35s the patch passed with JDK v1.8.0_66 +1 javac 2m 35s the patch passed +1 compile 2m 2s the patch passed with JDK v1.7.0_91 +1 javac 2m 2s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. +1 findbugs 4m 9s the patch passed +1 javadoc 1m 45s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 28s the patch passed with JDK v1.7.0_91 +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 91m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 79m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 218m 18s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.tracing.TestTracing   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786210/HDFS-9752.01.patch JIRA Issue HDFS-9752 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f0d6180ae6d9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 63c63e2 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14379/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14379/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14379/console This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        The fix looks good, but we don't need to restart the datanode 10 times in the test.

        With the sleeps, it take about 102 seconds to run this test case. If we just do 6 times, it becomes like 64 seconds and still fails without the fix. The use of Thread.sleep() in the test may not always be reliable , I guess there is no other choice. The shutdown should be quick since the datanode is only serving one writer. So the total sleep time per iteration has to be a bit longer than the client wait time of 4 seconds. I think we can get away with making the second sleep 2 seconds instead of 5 seconds. After making it restart 6 times and shrinking the sleep time, the test case finished in about 48 seconds.

        Show
        kihwal Kihwal Lee added a comment - The fix looks good, but we don't need to restart the datanode 10 times in the test. With the sleeps, it take about 102 seconds to run this test case. If we just do 6 times, it becomes like 64 seconds and still fails without the fix. The use of Thread.sleep() in the test may not always be reliable , I guess there is no other choice. The shutdown should be quick since the datanode is only serving one writer. So the total sleep time per iteration has to be a bit longer than the client wait time of 4 seconds. I think we can get away with making the second sleep 2 seconds instead of 5 seconds. After making it restart 6 times and shrinking the sleep time, the test case finished in about 48 seconds.
        Hide
        cnauroth Chris Nauroth added a comment -

        This is a really nice find! The change looks good to me.

        Kihwal Lee, regarding the test, I also am not seeing a more deterministic way to do it, barring massive refactoring that we probably don't want to get into. Do you think it could be made faster by configuring dfs.client.datanode-restart.timeout to something less than 4 seconds and then downtuning the test's sleeps accordingly? Would that make it too unpredictable?

        Show
        cnauroth Chris Nauroth added a comment - This is a really nice find! The change looks good to me. Kihwal Lee , regarding the test, I also am not seeing a more deterministic way to do it, barring massive refactoring that we probably don't want to get into. Do you think it could be made faster by configuring dfs.client.datanode-restart.timeout to something less than 4 seconds and then downtuning the test's sleeps accordingly? Would that make it too unpredictable?
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        A couple of alternatives for making the unit test faster:

        1. The test can just verify that pipelineRecoveryCount is not incremented after DN restart and pipeline recovery. If it is not incremented after one iteration the ++pipelineRecoveryCount > 5 check will never be triggered.
        2. Add a test hook to reduce the pipelineRecoveryCount threshold from 5 to 1.
        Show
        arpitagarwal Arpit Agarwal added a comment - A couple of alternatives for making the unit test faster: The test can just verify that pipelineRecoveryCount is not incremented after DN restart and pipeline recovery. If it is not incremented after one iteration the ++pipelineRecoveryCount > 5 check will never be triggered. Add a test hook to reduce the pipelineRecoveryCount threshold from 5 to 1.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Walter Su for this critical fix, Kihwal Lee for the reporting. I've been debugging this for while.

        1. Does it make sense to make pipelineRecoveryCount reconfigurable?

        2. Without the patch, it looks like not always true that there must be 'a permanent write failure can occur.', you mentioned. I attached a simple test.
        1). It writes data with hflush and hangs on there by holding the stream open
        2). manually bring down one of DNs in pipeline, recovery will be triggered
        3). 5 times later, pipeline will be closed. Data is successfully written to HDFS.

        Can you explain why there is no failure in the case? The only reason could be data is too small? Thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Walter Su for this critical fix, Kihwal Lee for the reporting. I've been debugging this for while. 1. Does it make sense to make pipelineRecoveryCount reconfigurable? 2. Without the patch, it looks like not always true that there must be 'a permanent write failure can occur.', you mentioned. I attached a simple test. 1). It writes data with hflush and hangs on there by holding the stream open 2). manually bring down one of DNs in pipeline, recovery will be triggered 3). 5 times later, pipeline will be closed. Data is successfully written to HDFS. Can you explain why there is no failure in the case? The only reason could be data is too small? Thanks.
        Hide
        walter.k.su Walter Su added a comment -

        Thanks for the advises. Uploaded 02 patch. The test now takes ~30s. But it's still difficult to remove the sleep used for waiting DN shutdown. I can use org.apache.mina.util.AvailablePortFinder.available(int port) to wait port to be free. But afraid of the extra dependency.

        Show
        walter.k.su Walter Su added a comment - Thanks for the advises. Uploaded 02 patch. The test now takes ~30s. But it's still difficult to remove the sleep used for waiting DN shutdown. I can use org.apache.mina.util.AvailablePortFinder.available(int port) to wait port to be free. But afraid of the extra dependency.
        Hide
        walter.k.su Walter Su added a comment -

        Hi, Xiaobing Zhou. I think the 'write failure' means the outputstream throw up a IOException and can't closed normally. In you test, if you just kill the DN without upgrade command, the client will consider it an error node and exclude it. It's not in the new pipeline.

        Show
        walter.k.su Walter Su added a comment - Hi, Xiaobing Zhou . I think the 'write failure' means the outputstream throw up a IOException and can't closed normally. In you test, if you just kill the DN without upgrade command, the client will consider it an error node and exclude it. It's not in the new pipeline.
        Hide
        kihwal Kihwal Lee added a comment -

        To avoid sleeping for arbitrary amount of time to wait for a datanode to shutdown, we can have DataNode#shutdown() to set a variable at the end to indicate shutdown is complete. It will be nice to have this in MiniDFSCluster#stopDataNode() as well, but that can be done in a separate jira.

        Show
        kihwal Kihwal Lee added a comment - To avoid sleeping for arbitrary amount of time to wait for a datanode to shutdown, we can have DataNode#shutdown() to set a variable at the end to indicate shutdown is complete. It will be nice to have this in MiniDFSCluster#stopDataNode() as well, but that can be done in a separate jira.
        Hide
        kihwal Kihwal Lee added a comment -

        This bug caused certain mapred AM logs to be missing sometimes. This is more serious for Tez AMs, since it actually causes a failure.

        Show
        kihwal Kihwal Lee added a comment - This bug caused certain mapred AM logs to be missing sometimes. This is more serious for Tez AMs, since it actually causes a failure.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 31s Maven dependency ordering for branch
        +1 mvninstall 10m 8s trunk passed
        +1 compile 2m 48s trunk passed with JDK v1.8.0_66
        +1 compile 2m 8s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 2m 3s trunk passed
        +1 mvneclipse 0m 32s trunk passed
        +1 findbugs 4m 54s trunk passed
        +1 javadoc 2m 27s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 18s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 20s Maven dependency ordering for patch
        +1 mvninstall 1m 49s the patch passed
        +1 compile 2m 42s the patch passed with JDK v1.8.0_66
        +1 javac 2m 42s the patch passed
        +1 compile 1m 56s the patch passed with JDK v1.7.0_91
        +1 javac 1m 56s the patch passed
        +1 checkstyle 0m 30s the patch passed
        +1 mvnsite 1m 57s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 5m 20s the patch passed
        +1 javadoc 2m 22s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 7s the patch passed with JDK v1.7.0_91
        +1 unit 1m 29s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 72m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 58m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        186m 26s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.server.datanode.TestBlockScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786471/HDFS-9752.02.patch
        JIRA Issue HDFS-9752
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a777dfac3231 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1bcfab8
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14404/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14404/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 10m 8s trunk passed +1 compile 2m 48s trunk passed with JDK v1.8.0_66 +1 compile 2m 8s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 35s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 4m 54s trunk passed +1 javadoc 2m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 18s trunk passed with JDK v1.7.0_91 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 1m 49s the patch passed +1 compile 2m 42s the patch passed with JDK v1.8.0_66 +1 javac 2m 42s the patch passed +1 compile 1m 56s the patch passed with JDK v1.7.0_91 +1 javac 1m 56s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 1m 57s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 20s the patch passed +1 javadoc 2m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 7s the patch passed with JDK v1.7.0_91 +1 unit 1m 29s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 72m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 58m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 186m 26s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.datanode.TestBlockScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786471/HDFS-9752.02.patch JIRA Issue HDFS-9752 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a777dfac3231 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1bcfab8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14404/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14404/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14404/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the advises. Uploaded 02 patch. The test now takes ~30s. But it's still difficult to remove the sleep used for waiting DN shutdown.

        Walter, what do you think of removing the loop in the test altogether and trying out this suggestion?
        The test can just verify that pipelineRecoveryCount is not incremented after DN restart and pipeline recovery. If it is not incremented after one iteration the ++pipelineRecoveryCount > 5 check will never be triggered.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the advises. Uploaded 02 patch. The test now takes ~30s. But it's still difficult to remove the sleep used for waiting DN shutdown. Walter, what do you think of removing the loop in the test altogether and trying out this suggestion? The test can just verify that pipelineRecoveryCount is not incremented after DN restart and pipeline recovery. If it is not incremented after one iteration the ++pipelineRecoveryCount > 5 check will never be triggered.
        Hide
        kihwal Kihwal Lee added a comment -

        Arpit's suggestion sounds good. We should avoid arbitrary sleeps in tests as much as possible. And I am all for making code more testable.

        Show
        kihwal Kihwal Lee added a comment - Arpit's suggestion sounds good. We should avoid arbitrary sleeps in tests as much as possible. And I am all for making code more testable.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        I agreed to avoid sleep in test with best efforts. Once my patch with sleep in test is committed and failed quite often in jenkins.

        Arpit Agarwal's proposal is good since pipelineRecoveryCount check is the key point. The current test is based on exception check that might not be deterministic due to sleep.

        Show
        xiaobingo Xiaobing Zhou added a comment - I agreed to avoid sleep in test with best efforts. Once my patch with sleep in test is committed and failed quite often in jenkins. Arpit Agarwal 's proposal is good since pipelineRecoveryCount check is the key point. The current test is based on exception check that might not be deterministic due to sleep.
        Hide
        walter.k.su Walter Su added a comment -

        The test can just verify that pipelineRecoveryCount is not incremented after DN restart and pipeline recovery...

        Good idea. Thanks. Uploaded 03 patch.

        It's still difficult to remove the sleep used for waiting DN shutdown.

        To avoid sleeping for arbitrary amount of time to wait for a datanode to shutdown, we can have DataNode#shutdown() to set a variable at the end to indicate shutdown is complete.

        I use thread name and GenericTestUtils.waitForThreadTermination(..) to do that. Hope it's ok to you.

        Show
        walter.k.su Walter Su added a comment - The test can just verify that pipelineRecoveryCount is not incremented after DN restart and pipeline recovery... Good idea. Thanks. Uploaded 03 patch. It's still difficult to remove the sleep used for waiting DN shutdown. To avoid sleeping for arbitrary amount of time to wait for a datanode to shutdown, we can have DataNode#shutdown() to set a variable at the end to indicate shutdown is complete. I use thread name and GenericTestUtils.waitForThreadTermination(..) to do that. Hope it's ok to you.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 28s Maven dependency ordering for branch
        +1 mvninstall 9m 6s trunk passed
        +1 compile 1m 50s trunk passed with JDK v1.8.0_66
        +1 compile 1m 26s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 28s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 3m 36s trunk passed
        +1 javadoc 1m 38s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 19s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 20s the patch passed
        +1 compile 1m 39s the patch passed with JDK v1.8.0_66
        +1 javac 1m 39s the patch passed
        +1 compile 1m 24s the patch passed with JDK v1.7.0_91
        +1 javac 1m 24s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 1m 25s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 56s the patch passed
        +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 16s the patch passed with JDK v1.7.0_91
        +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 87m 30s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 1m 12s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 86m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        216m 46s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.TestDataTransferKeepalive
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786675/HDFS-9752.03.patch
        JIRA Issue HDFS-9752
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e388108a52b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 29ae258
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14420/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14420/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 9m 6s trunk passed +1 compile 1m 50s trunk passed with JDK v1.8.0_66 +1 compile 1m 26s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 3m 36s trunk passed +1 javadoc 1m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 19s trunk passed with JDK v1.7.0_91 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 39s the patch passed with JDK v1.8.0_66 +1 javac 1m 39s the patch passed +1 compile 1m 24s the patch passed with JDK v1.7.0_91 +1 javac 1m 24s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 16s the patch passed with JDK v1.7.0_91 +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 87m 30s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 12s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 86m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 216m 46s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786675/HDFS-9752.03.patch JIRA Issue HDFS-9752 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e388108a52b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 29ae258 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14420/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14420/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14420/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1, Patch looks pretty good.
        In My eclipse, test takes less than 20 seconds.

        Test failures seems unrelated. TestHAAppend failure, have raised HDFS-9776.

        Show
        vinayrpet Vinayakumar B added a comment - +1, Patch looks pretty good. In My eclipse, test takes less than 20 seconds. Test failures seems unrelated. TestHAAppend failure, have raised HDFS-9776 .
        Hide
        kihwal Kihwal Lee added a comment -

        +1 from me too. Are you okay with the patch, Arpit Agarwal?

        Show
        kihwal Kihwal Lee added a comment - +1 from me too. Are you okay with the patch, Arpit Agarwal ?
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 from me too, thanks for fixing this Walter Su.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 from me too, thanks for fixing this Walter Su .
        Hide
        kihwal Kihwal Lee added a comment -

        Thanks, everyone. I will commit it shortly.

        Show
        kihwal Kihwal Lee added a comment - Thanks, everyone. I will commit it shortly.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9262 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9262/)
        HDFS-9752. Permanent write failures may happen to slow writers during (kihwal: rev 193d27de0a5d23a61cabd41162ebc3292d8526d1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestClientProtocolForPipelineRecovery.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9262 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9262/ ) HDFS-9752 . Permanent write failures may happen to slow writers during (kihwal: rev 193d27de0a5d23a61cabd41162ebc3292d8526d1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestClientProtocolForPipelineRecovery.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
        Hide
        kihwal Kihwal Lee added a comment -

        I've committed this to trunk, branch-2 and branch-2.8, but 2.7/2.6 will need a separate patch. Beside the DFSOutputstream split, ErrorState does not exist in 2.6/2.7.

        Show
        kihwal Kihwal Lee added a comment - I've committed this to trunk, branch-2 and branch-2.8, but 2.7/2.6 will need a separate patch. Beside the DFSOutputstream split, ErrorState does not exist in 2.6/2.7.
        Hide
        walter.k.su Walter Su added a comment -

        Thanks all for reviewing the patch.
        The patch depends on HDFS-9347. I just cherry-picked it to 2.6.5. Now I've uploaded the separate patch for 2.7/2.6.

        Show
        walter.k.su Walter Su added a comment - Thanks all for reviewing the patch. The patch depends on HDFS-9347 . I just cherry-picked it to 2.6.5. Now I've uploaded the separate patch for 2.7/2.6.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 16m 36s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        -1 mvninstall 1m 55s root in branch-2.7 failed.
        -1 compile 0m 12s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_72.
        -1 compile 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_95.
        +1 checkstyle 0m 9s branch-2.7 passed
        -1 mvnsite 0m 7s hadoop-hdfs in branch-2.7 failed.
        -1 mvneclipse 0m 14s hadoop-hdfs in branch-2.7 failed.
        -1 findbugs 0m 8s hadoop-hdfs in branch-2.7 failed.
        -1 javadoc 0m 8s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_72.
        -1 javadoc 0m 8s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_95.
        -1 mvninstall 0m 8s hadoop-hdfs in the patch failed.
        -1 compile 0m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 javac 0m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 compile 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 javac 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 checkstyle 0m 7s the patch passed
        -1 mvnsite 0m 8s hadoop-hdfs in the patch failed.
        -1 mvneclipse 0m 7s hadoop-hdfs in the patch failed.
        -1 whitespace 0m 1s The patch has 1772 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 40s The patch has 57 line(s) with tabs.
        -1 findbugs 0m 7s hadoop-hdfs in the patch failed.
        -1 javadoc 0m 7s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 javadoc 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 unit 0m 7s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 unit 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 asflicense 45m 57s Patch generated 56 ASF License warnings.
        68m 44s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:date2016-02-09
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786986/HDFS-9752-branch-2.7.03.patch
        JIRA Issue HDFS-9752
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 54d3cae5403e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / ef05096
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/whitespace-tabs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14432/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 45MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14432/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 16m 36s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. -1 mvninstall 1m 55s root in branch-2.7 failed. -1 compile 0m 12s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_72. -1 compile 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_95. +1 checkstyle 0m 9s branch-2.7 passed -1 mvnsite 0m 7s hadoop-hdfs in branch-2.7 failed. -1 mvneclipse 0m 14s hadoop-hdfs in branch-2.7 failed. -1 findbugs 0m 8s hadoop-hdfs in branch-2.7 failed. -1 javadoc 0m 8s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_72. -1 javadoc 0m 8s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_95. -1 mvninstall 0m 8s hadoop-hdfs in the patch failed. -1 compile 0m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 javac 0m 8s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 compile 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 javac 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 checkstyle 0m 7s the patch passed -1 mvnsite 0m 8s hadoop-hdfs in the patch failed. -1 mvneclipse 0m 7s hadoop-hdfs in the patch failed. -1 whitespace 0m 1s The patch has 1772 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 40s The patch has 57 line(s) with tabs. -1 findbugs 0m 7s hadoop-hdfs in the patch failed. -1 javadoc 0m 7s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 javadoc 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 unit 0m 7s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 45m 57s Patch generated 56 ASF License warnings. 68m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:date2016-02-09 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786986/HDFS-9752-branch-2.7.03.patch JIRA Issue HDFS-9752 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 54d3cae5403e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / ef05096 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14432/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14432/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 45MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14432/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the branch-2.6 patch. I committed it to branch-2.6. Thanks for taking care of this backport Walter Su.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the branch-2.6 patch. I committed it to branch-2.6. Thanks for taking care of this backport Walter Su .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1 for the branch-2.7 patch. I'll commit it shortly.

        Show
        ajisakaa Akira Ajisaka added a comment - +1 for the branch-2.7 patch. I'll commit it shortly.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed the branch-2.7 patch. Thanks Walter Su for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed the branch-2.7 patch. Thanks Walter Su for the contribution.
        Hide
        kihwal Kihwal Lee added a comment -

        Sorry, I was out sick for past 3 days. Thanks, Arpit Agarwal and Akira Ajisaka for reviewing and committing the patches, and Walter Su for providing the patches.

        Show
        kihwal Kihwal Lee added a comment - Sorry, I was out sick for past 3 days. Thanks, Arpit Agarwal and Akira Ajisaka for reviewing and committing the patches, and Walter Su for providing the patches.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            walter.k.su Walter Su
            Reporter:
            kihwal Kihwal Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            15 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development