[HDFS-9749] libhdfs++: RPC engine will attempt to close an asio socket before it's been opened

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: hdfs-client
• Assignee: James Clampffer
• Reporter: James Clampffer
• Created: 03/Feb/16 16:53
• Updated: 22/Mar/18 21:57
• Resolved: 04/Feb/16 14:10

Description

Libhdfs++ can work itself into a state where it needs to shutdown, in this case due to config issues, and during deconstruction attempts to call shutdown() and close() on an asio::tcp::socket that was never opened. This causes asio to throw a std::system_error which ends up terminating the process. See attached stack for details.

The fix is just to make sure the rpc_connection is actually connected before attempting to close it.

-  next_layer_.cancel();
-  next_layer_.close();
+  if(connected_) {
+    next_layer_.cancel();
+    next_layer_.close();
+  }
   connected_ = false;